Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

Issue 12094069: [autofill] Hook the sign-in button up to required actions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: isherman@ review Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
index d400769a8566db7769b9d83f6bac84b427559ada..227cb72d8f274862d6867ccc420d4fc36ada64a1 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
@@ -68,6 +68,8 @@ class AutofillDialogControllerImpl : public AutofillDialogController,
virtual string16 SignInText() const OVERRIDE;
virtual string16 SaveLocallyText() const OVERRIDE;
virtual string16 CancelSignInText() const OVERRIDE;
+ virtual bool IsSignedIn() const OVERRIDE;
+ virtual bool HasReceivedWalletResponse() const OVERRIDE;
virtual const DetailInputs& RequestedFieldsForSection(DialogSection section)
const OVERRIDE;
virtual ui::ComboboxModel* ComboboxModelForAutofillType(
@@ -145,6 +147,12 @@ class AutofillDialogControllerImpl : public AutofillDialogController,
// to the requesting site.
bool TransmissionWillBeSecure() const;
+ // Convenience method to get required actions.
+ std::vector<wallet::RequiredAction> RequiredActions() const;
Ilya Sherman 2013/01/31 04:35:44 nit: Remove dis guy.
Dan Beam 2013/01/31 21:04:26 Done.
+
+ // Convenience method to tell whether we need to address |action|.
+ bool HasRequiredAction(wallet::RequiredAction action) const;
+
// Initializes |suggested_email_| et al.
void GenerateSuggestionsModels();
@@ -192,10 +200,6 @@ class AutofillDialogControllerImpl : public AutofillDialogController,
// Like RequestedFieldsForSection, but returns a pointer.
DetailInputs* MutableRequestedFieldsForSection(DialogSection section);
- // Turns a required action into a notification.
- DialogNotification RequiredActionNotification(
- const std::vector<wallet::RequiredAction>& required_actions) const;
-
// Hides |popup_controller_|'s popup view, if it exists.
void HidePopup();

Powered by Google App Engine
This is Rietveld 408576698