[autofill] Hook the sign-in button up to required actions.

chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
index d400769a8566db7769b9d83f6bac84b427559ada..dd64e34915e0b10c43af820800a8651b9aa7e147 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
@@ -68,6 +68,8 @@ class AutofillDialogControllerImpl : public AutofillDialogController,
   virtual string16 SignInText() const OVERRIDE;
   virtual string16 SaveLocallyText() const OVERRIDE;
   virtual string16 CancelSignInText() const OVERRIDE;
+  virtual bool IsSignedIn() const OVERRIDE;
+  virtual bool HasReceivedWalletResponse() const OVERRIDE;
   virtual const DetailInputs& RequestedFieldsForSection(DialogSection section)
       const OVERRIDE;
   virtual ui::ComboboxModel* ComboboxModelForAutofillType(
@@ -145,6 +147,12 @@ class AutofillDialogControllerImpl : public AutofillDialogController,
   // to the requesting site.
   bool TransmissionWillBeSecure() const;
 
+  // Convenience method to get required actions.
+  std::vector<wallet::RequiredAction> RequiredActions() const;

[Ilya Sherman, 2013/01/31 02:33:07]

Hmm, this makes a copy.  Is that really what you want?  IMO it would be better
to just inline the code.

[Dan Beam, 2013/01/31 02:48:51]

Done. (this was used quite a few places before, now it's not)

+
+  // Convenience method to tell whether we need to address |action|.
+  bool RequiredActionApplies(wallet::RequiredAction action) const;

[Ilya Sherman, 2013/01/31 02:33:07]

Optional nit: When I read this method name and comment, I sort of expect it to
be called on actions that the server thinks are required, but which might not
apply for some reason.  Instead, you're basically checking whether the server
returned a specific required action or not.  Perhaps name this something like
HasRequiredAction() and update the comment to reduce ambiguity?

[Dan Beam, 2013/01/31 02:48:51]

Done.

+
   // Initializes |suggested_email_| et al.
   void GenerateSuggestionsModels();
 
@@ -192,10 +200,6 @@ class AutofillDialogControllerImpl : public AutofillDialogController,
   // Like RequestedFieldsForSection, but returns a pointer.
   DetailInputs* MutableRequestedFieldsForSection(DialogSection section);
 
-  // Turns a required action into a notification.
-  DialogNotification RequiredActionNotification(
-      const std::vector<wallet::RequiredAction>& required_actions) const;
-
   // Hides |popup_controller_|'s popup view, if it exists.
   void HidePopup();