Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 12094047: Disable size_t to int conversion data loss warnings in media win64 builds (Closed)

Created:
7 years, 10 months ago by wolenetz
Modified:
7 years, 10 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, DO NOT USE (jschuh), scottmg
Visibility:
Public.

Description

Disable size_t to int conversion data loss warnings in media win64 builds BUG=172415, 166496 TEST=local build of media target on win64 doesn't emit compiler warning 4267, with libvpx DEPS rolled privately per https://codereview.chromium.org/12087013/ R=scherkus@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179612

Patch Set 1 #

Total comments: 2

Patch Set 2 : Wrap comment within 80 columns #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M media/media.gyp View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
wolenetz
Please review. Thanks, Matt
7 years, 10 months ago (2013-01-29 22:32:13 UTC) #1
DaleCurtis
lgtm % nit. https://codereview.chromium.org/12094047/diff/1/media/media.gyp File media/media.gyp (right): https://codereview.chromium.org/12094047/diff/1/media/media.gyp#newcode672 media/media.gyp:672: # TODO(wolenetz): crbug.com/171009 fix size_t to ...
7 years, 10 months ago (2013-01-29 23:40:47 UTC) #2
wolenetz
https://codereview.chromium.org/12094047/diff/1/media/media.gyp File media/media.gyp (right): https://codereview.chromium.org/12094047/diff/1/media/media.gyp#newcode672 media/media.gyp:672: # TODO(wolenetz): crbug.com/171009 fix size_t to int truncations in ...
7 years, 10 months ago (2013-01-30 00:05:05 UTC) #3
Peter Kasting
Long term, are we going to be fixing the warnings?
7 years, 10 months ago (2013-01-30 00:10:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/12094047/5001
7 years, 10 months ago (2013-01-30 00:15:17 UTC) #5
wolenetz
On 2013/01/30 00:10:32, Peter Kasting wrote: > Long term, are we going to be fixing ...
7 years, 10 months ago (2013-01-30 00:18:25 UTC) #6
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) ash_unittests, aura_unittests, compositor_unittests, content_browsertests, content_unittests, interactive_ui_tests, ...
7 years, 10 months ago (2013-01-30 01:32:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/12094047/5001
7 years, 10 months ago (2013-01-30 02:09:26 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-01-30 12:24:12 UTC) #9
Message was sent while issue was closed.
Change committed as 179612

Powered by Google App Engine
This is Rietveld 408576698