Fix clearing of dead dependent codes and verify weak embedded maps on full GC.

src/lithium.cc

Index: src/lithium.cc
diff --git a/src/lithium.cc b/src/lithium.cc
index 108eb7f777fe2720853c8a121e3fd1bb67dc2962..d630b9fe4b2f250f1680ba148f65287c2b207c26 100644
--- a/src/lithium.cc
+++ b/src/lithium.cc
@@ -452,6 +452,12 @@ void LChunk::RegisterDependentCodeForEmbeddedMaps(Handle<Code> code) {
       }
     }
   }
+#ifdef VERIFY_HEAP
+  // This disables verification of weak embedded maps after full GC.
+  // AddDependentCode can cause a GC, which would observe the state where
+  // this code is not yet in the depended code lists of the embedded maps.
+  NoWeakEmbeddedMapsVerificationScope disable_verification_of_embedded_maps;

[ulan, 2013/01/29 15:02:58]

I tried putting AlwaysAllocateScope here, but then some cc tests fail because
they already have AlwaysAllocateScope and we cannot nest them.

[Michael Starzinger, 2013/01/31 14:27:50]

Yeah, it's unfortunate that we need a specialized scope for that, but I don't
see another solution either, so I am fine with it.

+#endif
   for (int i = 0; i < maps.length(); i++) {
     maps.at(i)->AddDependentCode(code);
   }