Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: src/lithium.cc

Issue 12094036: Fix clearing of dead dependent codes and verify weak embedded maps on full GC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address comments Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap-inl.h ('k') | src/mark-compact.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 434 matching lines...) Expand 10 before | Expand all | Expand 10 after
445 for (RelocIterator it(*code, mode_mask); !it.done(); it.next()) { 445 for (RelocIterator it(*code, mode_mask); !it.done(); it.next()) {
446 RelocInfo::Mode mode = it.rinfo()->rmode(); 446 RelocInfo::Mode mode = it.rinfo()->rmode();
447 if (mode == RelocInfo::EMBEDDED_OBJECT && 447 if (mode == RelocInfo::EMBEDDED_OBJECT &&
448 it.rinfo()->target_object()->IsMap()) { 448 it.rinfo()->target_object()->IsMap()) {
449 Handle<Map> map(Map::cast(it.rinfo()->target_object())); 449 Handle<Map> map(Map::cast(it.rinfo()->target_object()));
450 if (map->CanTransition()) { 450 if (map->CanTransition()) {
451 maps.Add(map, zone()); 451 maps.Add(map, zone());
452 } 452 }
453 } 453 }
454 } 454 }
455 #ifdef VERIFY_HEAP
456 // This disables verification of weak embedded maps after full GC.
457 // AddDependentCode can cause a GC, which would observe the state where
458 // this code is not yet in the depended code lists of the embedded maps.
459 NoWeakEmbeddedMapsVerificationScope disable_verification_of_embedded_maps;
460 #endif
455 for (int i = 0; i < maps.length(); i++) { 461 for (int i = 0; i < maps.length(); i++) {
456 maps.at(i)->AddDependentCode(code); 462 maps.at(i)->AddDependentCode(code);
457 } 463 }
458 } 464 }
459 465
460 } } // namespace v8::internal 466 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/heap-inl.h ('k') | src/mark-compact.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698