chrome/browser/ui/views/extensions/extension_install_dialog_view.cc - Issue 12094034: Add a link (to view Permissions) to the Extension details on chrome://extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

Issue 12094034: Add a link (to view Permissions) to the Extension details on chrome://extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/extensions/extensions.html ('k') | chrome/browser/ui/webui/extensions/extension_settings_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

===================================================================

--- chrome/browser/ui/views/extensions/extension_install_dialog_view.cc (revision 179321)

+++ chrome/browser/ui/views/extensions/extension_install_dialog_view.cc (working copy)

@@ -102,6 +102,7 @@

private:

// views::DialogDelegateView:

+ virtual int GetDialogButtons() const OVERRIDE;

virtual string16 GetDialogButtonLabel(ui::DialogButton button) const OVERRIDE;

virtual int GetDefaultDialogButton() const OVERRIDE;

virtual bool Cancel() OVERRIDE;

@@ -528,6 +529,14 @@

GetWidget()->SetSize(GetWidget()->non_client_view()->GetPreferredSize());

}

+int ExtensionInstallDialogView::GetDialogButtons() const {

+ int buttons = prompt_.GetDialogButtons();

+ // Simply having just an OK button is *not* supported. See comment on function

+ // GetDialogButtons in dialog_delegate.h for reasons.

+ DCHECK_GT(buttons & ui::DIALOG_BUTTON_CANCEL, 0);

+ return buttons;

string16 ExtensionInstallDialogView::GetDialogButtonLabel(

ui::DialogButton button) const {

switch (button) {