Chromium Code Reviews
Help | Chromium Project | Sign in
(524)

Issue 12094034: Add a link (to view Permissions) to the Extension details on chrome://extensions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by Finnur
Modified:
1 year, 2 months ago
CC:
chromium-reviews_chromium.org, Aaron Boodman, arv, tfarina, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Add a link (to view Permissions) to the Extension details on chrome://extensions.

BUG=170742
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179916

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -3 lines) Lint Patch
M chrome/app/generated_resources.grd View 4 chunks +14 lines, -1 line 0 comments 0 errors Download
M chrome/browser/extensions/extension_install_prompt.h View 3 chunks +9 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/extensions/extension_install_prompt.cc View 9 chunks +32 lines, -1 line 0 comments 0 errors Download
M chrome/browser/resources/extensions/extension_list.js View 2 chunks +8 lines, -1 line 0 comments 0 errors Download
M chrome/browser/resources/extensions/extensions.html View 1 1 chunk +4 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.cc View 1 2 chunks +9 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.h View 5 chunks +12 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 4 chunks +25 lines, -0 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 9
Finnur
mpcomplete: chrome/browser/extensions/* chrome/browser/ui/views/extensions/extension_install_dialog_view.cc and generated_resources.grd jhawkins: chrome/browser/resources/* chrome/browser/ui/webui/extensions/* sky: OWNERS for extension_install_dialog_view.cc
1 year, 2 months ago #1
sky
LGTM https://codereview.chromium.org/12094034/diff/1/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc File chrome/browser/ui/views/extensions/extension_install_dialog_view.cc (right): https://codereview.chromium.org/12094034/diff/1/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc#newcode536 chrome/browser/ui/views/extensions/extension_install_dialog_view.cc:536: DCHECK((buttons & ui::DIALOG_BUTTON_CANCEL) > 0); DCHECK_GT
1 year, 2 months ago #2
James Hawkins
https://codereview.chromium.org/12094034/diff/1/chrome/browser/resources/extensions/extensions.html File chrome/browser/resources/extensions/extensions.html (right): https://codereview.chromium.org/12094034/diff/1/chrome/browser/resources/extensions/extensions.html#newcode108 chrome/browser/resources/extensions/extensions.html:108: href="#"></a> nit: Wrapped lines must have the closing tag ...
1 year, 2 months ago #3
Matt Perry
lgtm
1 year, 2 months ago #4
Finnur
Addressed comments. James, PTAL. https://codereview.chromium.org/12094034/diff/1/chrome/browser/ui/webui/extensions/extension_settings_handler.cc File chrome/browser/ui/webui/extensions/extension_settings_handler.cc (right): https://codereview.chromium.org/12094034/diff/1/chrome/browser/ui/webui/extensions/extension_settings_handler.cc#newcode510 chrome/browser/ui/webui/extensions/extension_settings_handler.cc:510: CHECK(false); Because this should never ...
1 year, 2 months ago #5
Finnur
jhawkins: ping.
1 year, 2 months ago #6
James Hawkins
lgtm
1 year, 2 months ago #7
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/finnur@chromium.org/12094034/10
1 year, 2 months ago #8
I haz the power (commit-bot)
1 year, 2 months ago #9
Message was sent while issue was closed.
Change committed as 179916
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6