Make startup timing independent of host performance

Make startup timing independent of host performance

Add a method StartActivityTimed that puts a message in the log and starts
the activity in a single adb shell command, and then uses the log message
to get the activity start time, hence making the timing independent of
the time it takes to turn adb around.

BUG=172616
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179429

[Sami, 2013-01-29 15:07:59]

https://codereview.chromium.org/12094029/diff/2001/build/android/pylib/androi...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/12094029/diff/2001/build/android/pylib/androi...
build/android/pylib/android_commands.py:533: def _ActivityCmd(self, package,
activity, wait_for_completion, action,
Bikeshed: _GetActivityCommand?

https://codereview.chromium.org/12094029/diff/2001/build/android/pylib/androi...
build/android/pylib/android_commands.py:549: """
Could also document the return value here.

https://codereview.chromium.org/12094029/diff/2001/build/android/pylib/androi...
build/android/pylib/android_commands.py:583: """Starts |package|'s activity on
the device.
Rather than having three copies of more or less the same docstring, let's make
the others refer to this one.

https://codereview.chromium.org/12094029/diff/2001/build/android/pylib/androi...
build/android/pylib/android_commands.py:621: """
Return value description missing here too.

https://codereview.chromium.org/12094029/diff/2001/build/android/pylib/androi...
build/android/pylib/android_commands.py:625: self.RunShellCommand('log starting
activity; ' + cmd)
This works nicely, but I was wondering if you considered just looking for the
message from ActivityManager:

I/ActivityManager(  510): START u0 {act=android.intent.action.VIEW
dat=http://www.google.com flg=0x10000000
cmp=com.google.android.apps.chrome/.Main} from pid 27778

[aberent, 2013-01-29 17:02:18]

https://codereview.chromium.org/12094029/diff/2001/build/android/pylib/androi...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/12094029/diff/2001/build/android/pylib/androi...
build/android/pylib/android_commands.py:533: def _ActivityCmd(self, package,
activity, wait_for_completion, action,
On 2013/01/29 15:07:59, Sami wrote:
> Bikeshed: _GetActivityCommand?

Done.

https://codereview.chromium.org/12094029/diff/2001/build/android/pylib/androi...
build/android/pylib/android_commands.py:549: """
On 2013/01/29 15:07:59, Sami wrote:
> Could also document the return value here.

Done.

https://codereview.chromium.org/12094029/diff/2001/build/android/pylib/androi...
build/android/pylib/android_commands.py:583: """Starts |package|'s activity on
the device.
On 2013/01/29 15:07:59, Sami wrote:
> Rather than having three copies of more or less the same docstring, let's make
> the others refer to this one.

Done.

https://codereview.chromium.org/12094029/diff/2001/build/android/pylib/androi...
build/android/pylib/android_commands.py:621: """
On 2013/01/29 15:07:59, Sami wrote:
> Return value description missing here too.

Done.

https://codereview.chromium.org/12094029/diff/2001/build/android/pylib/androi...
build/android/pylib/android_commands.py:625: self.RunShellCommand('log starting
activity; ' + cmd)
On 2013/01/29 15:07:59, Sami wrote:
> This works nicely, but I was wondering if you considered just looking for the
> message from ActivityManager:
> 
> I/ActivityManager(  510): START u0 {act=android.intent.action.VIEW
> http://dat=http://www.google.com flg=0x10000000
> cmp=com.google.android.apps.chrome/.Main} from pid 27778

That is what it used to do, but we don't seem to get the ActivityManager message
on S3.

[Sami, 2013-01-29 17:48:56]

Thanks, lgtm.

> That is what it used to do, but we don't seem to get the ActivityManager
message on S3.

I see, S3 just had to be different here too.

https://codereview.chromium.org/12094029/diff/6001/build/android/pylib/androi...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/12094029/diff/6001/build/android/pylib/androi...
build/android/pylib/android_commands.py:596:
action='android.intent.action.VIEW',
Looks like one space of indentation is missing.

[aberent, 2013-01-29 18:34:10]

https://codereview.chromium.org/12094029/diff/6001/build/android/pylib/androi...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/12094029/diff/6001/build/android/pylib/androi...
build/android/pylib/android_commands.py:596:
action='android.intent.action.VIEW',
On 2013/01/29 17:48:56, Sami wrote:
> Looks like one space of indentation is missing.

Done.

[commit-bot: I haz the power, 2013-01-29 18:37:04]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[John Knottenbelt, 2013-01-29 18:50:28]

lgtm

[commit-bot: I haz the power, 2013-01-29 18:55:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aberent@chromium.org/12094029/9001

[commit-bot: I haz the power, 2013-01-29 21:56:19]

Change committed as 179429