Issue 12094008: Bugfix: to add missing prefix for return type from javap.

Issue 12094008: Bugfix: to add missing prefix for return type from javap. (Closed)

Created:
7 years, 11 months ago by dwkang1

Modified:
7 years, 10 months ago

Reviewers:
bulach, Leandro Graciá Gil

CC:
chromium-reviews, erikwright+watch_chromium.org, ycheo (away), googletv-nikita_google.com

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Bugfix: to add missing prefix for return type from javap. BUG=170345 TEST=passes jni_generator_tests and works well with android/media/MediaCodec::getInputBuffers(). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180965

Patch Set 1 #

Patch Set 2 : adding unittests #

Total comments: 2

Patch Set 3 : removing spaces. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	base/android/jni_generator/jni_generator.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	base/android/jni_generator/jni_generator_tests.py	View	1 2	2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

bulach

lgtm with a nit below, thanks! (and apologies for the delay, I was out for ...

7 years, 10 months ago (2013-02-04 14:44:24 UTC) #4

dwkang1

Thanks for the review. BTW, I am not a committer. Could you commit this patch? ...

7 years, 10 months ago (2013-02-05 01:46:28 UTC) #5

bulach

sure, no probl! I just put through some try bots, will check the CQ bit ...

7 years, 10 months ago (2013-02-05 14:26:35 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dwkang@chromium.org/12094008/9001

7 years, 10 months ago (2013-02-05 15:25:54 UTC) #7

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=108315

7 years, 10 months ago (2013-02-05 18:10:18 UTC) #8

dwkang1

The failure doesn't look related to this patch. Could you run the CQ again? Thanks!

7 years, 10 months ago (2013-02-06 02:28:01 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dwkang@chromium.org/12094008/9001

7 years, 10 months ago (2013-02-06 11:06:48 UTC) #10

Message was sent while issue was closed.

Change committed as 180965

Expand Messages | Collapse Messages