Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 12093086: Avoid leaking TestWebIDBFactory instances, and reset (Closed)

Created:
7 years, 10 months ago by darin (slow to review)
Modified:
7 years, 10 months ago
Reviewers:
jsbell
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Avoid leaking TestWebIDBFactory instances, and reset the TestWebIDBFactory instance between layout tests. (The last part depends on a WebKit patch to actually call ResetTestEnvironment.) R=jsbell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179967

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M webkit/support/test_webkit_platform_support.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 2 chunks +7 lines, -1 line 0 comments Download
M webkit/support/webkit_support.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
darin (slow to review)
7 years, 10 months ago (2013-01-31 08:48:24 UTC) #1
darin (slow to review)
NOTE: This patch also makes it so that it should be safe to land the ...
7 years, 10 months ago (2013-01-31 08:55:33 UTC) #2
jsbell
lgtm on its own - do you have the webkit patches lined up?
7 years, 10 months ago (2013-01-31 16:37:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/12093086/11002
7 years, 10 months ago (2013-01-31 18:56:46 UTC) #4
pilgrim_google
On 2013/01/31 16:37:24, jsbell wrote: > lgtm on its own - do you have the ...
7 years, 10 months ago (2013-01-31 20:03:45 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-01-31 21:32:04 UTC) #6
Message was sent while issue was closed.
Change committed as 179967

Powered by Google App Engine
This is Rietveld 408576698