chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc - Issue 12093075: Move the panel to the root window where the mouse click occurred.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc

Issue 12093075: Move the panel to the root window where the mouse click occurred. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: updated comment Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.h ('k') | chrome/browser/ui/ash/launcher/launcher_item_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc

index a6c27a303c8b16e5dd4e485f94503cc67d1d08aa..04cad22317916318194d9471783d8c808b21be5e 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.cc

@@ -102,7 +102,7 @@ class AppShortcutLauncherItemController : public LauncherItemController {

// TODO: maybe should treat as unpin?

}

- virtual void Clicked() OVERRIDE {

+ virtual void Clicked(const ui::Event& event) OVERRIDE {

Activate();

}

@@ -810,9 +810,9 @@ void ChromeLauncherControllerPerBrowser::OnBrowserShortcutClicked(

void ChromeLauncherControllerPerBrowser::ItemClicked(

const ash::LauncherItem& item,

- int event_flags) {

+ const ui::Event& event) {

DCHECK(HasItemController(item.id));

- id_to_item_controller_map_[item.id]->Clicked();

+ id_to_item_controller_map_[item.id]->Clicked(event);

}

int ChromeLauncherControllerPerBrowser::GetBrowserShortcutResourceId() {