Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3612)

Unified Diff: chrome/common/extensions/permissions/permission_set.h

Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/permission_set.h
diff --git a/chrome/common/extensions/permissions/permission_set.h b/chrome/common/extensions/permissions/permission_set.h
index 6c5288768f9a7c5938b51e23aa1ed4b517eea770..80164996723287155440e7b7640a34b64752e9d3 100644
--- a/chrome/common/extensions/permissions/permission_set.h
+++ b/chrome/common/extensions/permissions/permission_set.h
@@ -14,13 +14,14 @@
#include "base/memory/ref_counted.h"
#include "base/memory/singleton.h"
#include "base/string16.h"
-#include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/manifest.h"
#include "chrome/common/extensions/permissions/api_permission.h"
#include "chrome/common/extensions/permissions/api_permission_set.h"
#include "chrome/common/extensions/permissions/permission_message.h"
#include "extensions/common/url_pattern_set.h"
namespace extensions {
+class Extension;
// The PermissionSet is an immutable class that encapsulates an
// extension's permissions. The class exposes set operations for combining and
@@ -80,12 +81,12 @@ class PermissionSet
// Gets the localized permission messages that represent this set.
// The set of permission messages shown varies by extension type.
- PermissionMessages GetPermissionMessages(Extension::Type extension_type)
+ PermissionMessages GetPermissionMessages(Manifest::Type extension_type)
const;
// Gets the localized permission messages that represent this set (represented
// as strings). The set of permission messages shown varies by extension type.
- std::vector<string16> GetWarningMessages(Extension::Type extension_type)
+ std::vector<string16> GetWarningMessages(Manifest::Type extension_type)
const;
// Returns true if this is an empty set (e.g., the default permission set).
« no previous file with comments | « chrome/common/extensions/manifest_url_handler.cc ('k') | chrome/common/extensions/permissions/permission_set.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698