Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: chrome/common/extensions/manifest_url_handler.cc

Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_url_handler.cc
diff --git a/chrome/common/extensions/manifest_url_handler.cc b/chrome/common/extensions/manifest_url_handler.cc
index e11c1f6c508c4831a5b5459a95a36a67bc36f490..e1f158ce82c50b9fa7851e76402cace9f7847a72 100644
--- a/chrome/common/extensions/manifest_url_handler.cc
+++ b/chrome/common/extensions/manifest_url_handler.cc
@@ -227,7 +227,7 @@ bool URLOverridesHandler::Parse(Extension* extension, string16* error) {
#endif
#if defined(FILE_MANAGER_EXTENSION)
is_override = (is_override &&
- !(extension->location() == Extension::COMPONENT &&
+ !(extension->location() == Manifest::COMPONENT &&
page == chrome::kChromeUIFileManagerHost));
#endif
@@ -240,7 +240,7 @@ bool URLOverridesHandler::Parse(Extension* extension, string16* error) {
// For component extensions, add override URL to extent patterns.
if (extension->is_legacy_packaged_app() &&
- extension->location() == Extension::COMPONENT) {
+ extension->location() == Manifest::COMPONENT) {
URLPattern pattern(URLPattern::SCHEME_CHROMEUI);
std::string url = base::StringPrintf(kOverrideExtentUrlPatternFormat,
page.c_str());
« no previous file with comments | « chrome/common/extensions/manifest_unittest.cc ('k') | chrome/common/extensions/permissions/permission_set.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698