chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc - Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc

Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_old_unittest.cc ('k') | chrome/common/extensions/manifest_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc

index aeed717d79f3abd6b093e6f3e3a761bb474e236c..f51a4c3f6623428a2a197e30e9b2006c4d32abc9 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc

@@ -23,13 +23,13 @@ class UpdateURLManifestTest : public ExtensionManifestTest {

TEST_F(UpdateURLManifestTest, UpdateUrls) {

// Test several valid update urls

Testcase testcases[] = {

- Testcase("update_url_valid_1.json", Extension::INTERNAL,

+ Testcase("update_url_valid_1.json", extensions::Manifest::INTERNAL,

Extension::NO_FLAGS),

- Testcase("update_url_valid_2.json", Extension::INTERNAL,

+ Testcase("update_url_valid_2.json", extensions::Manifest::INTERNAL,

Extension::NO_FLAGS),

- Testcase("update_url_valid_3.json", Extension::INTERNAL,

+ Testcase("update_url_valid_3.json", extensions::Manifest::INTERNAL,

Extension::NO_FLAGS),

- Testcase("update_url_valid_4.json", Extension::INTERNAL,

+ Testcase("update_url_valid_4.json", extensions::Manifest::INTERNAL,

Extension::NO_FLAGS)

};

RunTestcases(testcases, arraysize(testcases),

@@ -38,11 +38,11 @@ TEST_F(UpdateURLManifestTest, UpdateUrls) {

// Test some invalid update urls

Testcase testcases2[] = {

Testcase("update_url_invalid_1.json", errors::kInvalidUpdateURL,

- Extension::INTERNAL, Extension::NO_FLAGS),

+ extensions::Manifest::INTERNAL, Extension::NO_FLAGS),

Testcase("update_url_invalid_2.json", errors::kInvalidUpdateURL,

- Extension::INTERNAL, Extension::NO_FLAGS),

+ extensions::Manifest::INTERNAL, Extension::NO_FLAGS),

Testcase("update_url_invalid_3.json", errors::kInvalidUpdateURL,

- Extension::INTERNAL, Extension::NO_FLAGS)

+ extensions::Manifest::INTERNAL, Extension::NO_FLAGS)

};

RunTestcases(testcases2, arraysize(testcases2),

EXPECT_TYPE_ERROR);