Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4787)

Unified Diff: chrome/common/extensions/extension_builder.h

Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome/common/extensions/extension_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_builder.h
diff --git a/chrome/common/extensions/extension_builder.h b/chrome/common/extensions/extension_builder.h
index 209b70494e9ce5bbc8dc45b6b3bcab71cabaf6d9..b62092b752e75bb21158ae03b9e30eadca8e33bc 100644
--- a/chrome/common/extensions/extension_builder.h
+++ b/chrome/common/extensions/extension_builder.h
@@ -5,12 +5,14 @@
#ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_BUILDER_H_
#define CHROME_COMMON_EXTENSIONS_EXTENSION_BUILDER_H_
+#include "base/file_path.h"
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
-#include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/manifest.h"
#include "chrome/common/extensions/value_builder.h"
namespace extensions {
+class Extension;
// An easier way to create extensions than Extension::Create. The
// constructor sets up some defaults which are customized using the
@@ -27,8 +29,8 @@ class ExtensionBuilder {
// Defaults to FilePath().
ExtensionBuilder& SetPath(const FilePath& path);
- // Defaults to Extension::LOAD.
- ExtensionBuilder& SetLocation(Extension::Location location);
+ // Defaults to Manifest::LOAD.
+ ExtensionBuilder& SetLocation(Manifest::Location location);
ExtensionBuilder& SetManifest(scoped_ptr<base::DictionaryValue> manifest);
ExtensionBuilder& SetManifest(DictionaryBuilder& manifest_builder) {
@@ -42,7 +44,7 @@ class ExtensionBuilder {
private:
FilePath path_;
- Extension::Location location_;
+ Manifest::Location location_;
scoped_ptr<base::DictionaryValue> manifest_;
int flags_;
std::string id_;
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome/common/extensions/extension_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698