Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1725)

Unified Diff: chrome/browser/extensions/updater/extension_downloader.cc

Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/updater/extension_downloader.cc
diff --git a/chrome/browser/extensions/updater/extension_downloader.cc b/chrome/browser/extensions/updater/extension_downloader.cc
index 7a4336f8d45df34888e44c6aa5bbfe13201c1e99..aed02ff45309c7c2a45714715cac5324282e92f6 100644
--- a/chrome/browser/extensions/updater/extension_downloader.cc
+++ b/chrome/browser/extensions/updater/extension_downloader.cc
@@ -220,7 +220,7 @@ bool ExtensionDownloader::AddPendingExtension(const std::string& id,
Version version("0.0.0.0");
DCHECK(version.IsValid());
- return AddExtensionData(id, version, Extension::TYPE_UNKNOWN, update_url, "",
+ return AddExtensionData(id, version, Manifest::TYPE_UNKNOWN, update_url, "",
request_id);
}
@@ -256,7 +256,7 @@ void ExtensionDownloader::StartBlacklistUpdate(
bool ExtensionDownloader::AddExtensionData(const std::string& id,
const Version& version,
- Extension::Type extension_type,
+ Manifest::Type extension_type,
const GURL& extension_update_url,
const std::string& update_url_data,
int request_id) {
@@ -290,21 +290,21 @@ bool ExtensionDownloader::AddExtensionData(const std::string& id,
}
switch (extension_type) {
- case Extension::TYPE_THEME:
+ case Manifest::TYPE_THEME:
++url_stats_.theme_count;
break;
- case Extension::TYPE_EXTENSION:
- case Extension::TYPE_USER_SCRIPT:
+ case Manifest::TYPE_EXTENSION:
+ case Manifest::TYPE_USER_SCRIPT:
++url_stats_.extension_count;
break;
- case Extension::TYPE_HOSTED_APP:
- case Extension::TYPE_LEGACY_PACKAGED_APP:
+ case Manifest::TYPE_HOSTED_APP:
+ case Manifest::TYPE_LEGACY_PACKAGED_APP:
++url_stats_.app_count;
break;
- case Extension::TYPE_PLATFORM_APP:
+ case Manifest::TYPE_PLATFORM_APP:
++url_stats_.platform_app_count;
break;
- case Extension::TYPE_UNKNOWN:
+ case Manifest::TYPE_UNKNOWN:
default:
++url_stats_.pending_count;
break;
« no previous file with comments | « chrome/browser/extensions/updater/extension_downloader.h ('k') | chrome/browser/extensions/updater/extension_updater.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698