Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: chrome/browser/extensions/image_loading_tracker_unittest.cc

Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/image_loading_tracker.cc ('k') | chrome/browser/extensions/installed_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/image_loading_tracker_unittest.cc
diff --git a/chrome/browser/extensions/image_loading_tracker_unittest.cc b/chrome/browser/extensions/image_loading_tracker_unittest.cc
index 5754d942f01efbde90a6674de76756f4f909c3ba..bb046d6e328d8eeb1de693f755c801a8845fd33e 100644
--- a/chrome/browser/extensions/image_loading_tracker_unittest.cc
+++ b/chrome/browser/extensions/image_loading_tracker_unittest.cc
@@ -13,6 +13,7 @@
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/extensions/extension_icon_set.h"
#include "chrome/common/extensions/extension_resource.h"
+#include "chrome/common/extensions/manifest.h"
#include "content/public/browser/notification_service.h"
#include "content/public/test/test_browser_thread.h"
#include "grit/component_extension_resources.h"
@@ -24,6 +25,7 @@
using content::BrowserThread;
using extensions::Extension;
+using extensions::Manifest;
class ImageLoadingTrackerTest : public testing::Test,
public ImageLoadingTracker::Observer {
@@ -58,7 +60,7 @@ class ImageLoadingTrackerTest : public testing::Test,
}
scoped_refptr<Extension> CreateExtension(const char* name,
- Extension::Location location) {
+ Manifest::Location location) {
// Create and load an extension.
FilePath test_file;
if (!PathService::Get(chrome::DIR_TEST_DATA, &test_file)) {
@@ -81,7 +83,7 @@ class ImageLoadingTrackerTest : public testing::Test,
if (!valid_value.get())
return NULL;
- if (location == Extension::COMPONENT) {
+ if (location == Manifest::COMPONENT) {
if (!PathService::Get(chrome::DIR_RESOURCES, &test_file)) {
EXPECT_FALSE(true);
return NULL;
@@ -111,7 +113,7 @@ class ImageLoadingTrackerTest : public testing::Test,
// Tests asking ImageLoadingTracker to cache pushes the result to the Extension.
TEST_F(ImageLoadingTrackerTest, Cache) {
scoped_refptr<Extension> extension(CreateExtension(
- "image_loading_tracker", Extension::INVALID));
+ "image_loading_tracker", Manifest::INVALID_LOCATION));
ASSERT_TRUE(extension.get() != NULL);
ExtensionResource image_resource =
@@ -161,7 +163,7 @@ TEST_F(ImageLoadingTrackerTest, Cache) {
// problems.
TEST_F(ImageLoadingTrackerTest, DeleteExtensionWhileWaitingForCache) {
scoped_refptr<Extension> extension(CreateExtension(
- "image_loading_tracker", Extension::INVALID));
+ "image_loading_tracker", Manifest::INVALID_LOCATION));
ASSERT_TRUE(extension.get() != NULL);
ExtensionResource image_resource =
@@ -203,7 +205,7 @@ TEST_F(ImageLoadingTrackerTest, DeleteExtensionWhileWaitingForCache) {
// Tests loading multiple dimensions of the same image.
TEST_F(ImageLoadingTrackerTest, MultipleImages) {
scoped_refptr<Extension> extension(CreateExtension(
- "image_loading_tracker", Extension::INVALID));
+ "image_loading_tracker", Manifest::INVALID_LOCATION));
ASSERT_TRUE(extension.get() != NULL);
std::vector<ImageLoadingTracker::ImageRepresentation> info_list;
« no previous file with comments | « chrome/browser/extensions/image_loading_tracker.cc ('k') | chrome/browser/extensions/installed_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698