chrome/browser/extensions/api/management/management_apitest.cc - Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/management_apitest.cc

Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/management/management_api.cc ('k') | chrome/browser/extensions/api/management/management_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/management_apitest.cc

diff --git a/chrome/browser/extensions/api/management/management_apitest.cc b/chrome/browser/extensions/api/management/management_apitest.cc

index b1161d546fcb6a07eb02508f7af77daff461dcb0..cdaf59b5ac7307141ce6dad742423364f1912549 100644

--- a/chrome/browser/extensions/api/management/management_apitest.cc

+++ b/chrome/browser/extensions/api/management/management_apitest.cc

@@ -86,7 +86,7 @@ class ExtensionManagementApiTest : public ExtensionApiTest {

void InstallNamedExtension(const FilePath& path,

const std::string& name,

- Extension::Location install_source) {

+ Manifest::Location install_source) {

const Extension* extension = InstallExtension(path.AppendASCII(name), 1,

install_source);

ASSERT_TRUE(extension);

@@ -101,11 +101,11 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, Basics) {

LoadExtensions();

FilePath basedir = test_data_dir_.AppendASCII("management");

- InstallNamedExtension(basedir, "internal_extension", Extension::INTERNAL);

+ InstallNamedExtension(basedir, "internal_extension", Manifest::INTERNAL);

InstallNamedExtension(basedir, "external_extension",

- Extension::EXTERNAL_PREF);

+ Manifest::EXTERNAL_PREF);

InstallNamedExtension(basedir, "admin_extension",

- Extension::EXTERNAL_POLICY_DOWNLOAD);

+ Manifest::EXTERNAL_POLICY_DOWNLOAD);

ASSERT_TRUE(RunExtensionSubtest("management/test", "basics.html"));

}