Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2953)

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
index 826a4ba7b05d3925e3d654b275ea85021fc9ee2d..9eefa6812ad919b4381c087f908f87a311f2cfe2 100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc
+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
@@ -142,7 +142,7 @@ scoped_ptr<developer::ItemInfo>
NOTREACHED();
}
- if (item.location() == Extension::LOAD) {
+ if (item.location() == Manifest::LOAD) {
info->path.reset(
new std::string(UTF16ToUTF8(item.path().LossyDisplayName())));
}
@@ -150,8 +150,8 @@ scoped_ptr<developer::ItemInfo>
info->incognito_enabled = service->IsIncognitoEnabled(item.id());
info->wants_file_access = item.wants_file_access();
info->allow_file_access = service->AllowFileAccess(&item);
- info->allow_reload = (item.location() == Extension::LOAD);
- info->is_unpacked = (item.location() == Extension::LOAD);
+ info->allow_reload = (item.location() == Manifest::LOAD);
+ info->is_unpacked = (item.location() == Manifest::LOAD);
info->terminated = service->terminated_extensions()->Contains(item.id());
info->allow_incognito = item.can_be_incognito_enabled();
@@ -195,7 +195,7 @@ void DeveloperPrivateGetItemsInfoFunction::AddItemsInfo(
for (ExtensionSet::const_iterator iter = items.begin();
iter != items.end(); ++iter) {
const Extension& item = **iter;
- if (item.location() == Extension::COMPONENT)
+ if (item.location() == Manifest::COMPONENT)
continue; // Skip built-in extensions / apps;
item_list->push_back(make_linked_ptr<developer::ItemInfo>(
CreateItemInfo(item, system, false).release()));

Powered by Google App Engine
This is Rietveld 408576698