Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2824)

Unified Diff: chrome/browser/extensions/extension_function_test_utils.cc

Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_function_test_utils.cc
diff --git a/chrome/browser/extensions/extension_function_test_utils.cc b/chrome/browser/extensions/extension_function_test_utils.cc
index d352966effec3bc49c29530b4a16cb4bf7243d27..d7a7b4e6ca3b588b389cf584818fda2fce8474d5 100644
--- a/chrome/browser/extensions/extension_function_test_utils.cc
+++ b/chrome/browser/extensions/extension_function_test_utils.cc
@@ -14,11 +14,13 @@
#include "chrome/browser/extensions/extension_function_dispatcher.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/manifest.h"
#include "chrome/test/base/ui_test_utils.h"
#include "testing/gtest/include/gtest/gtest.h"
using content::WebContents;
using extensions::Extension;
+using extensions::Manifest;
namespace keys = extensions::tabs_constants;
namespace {
@@ -102,11 +104,11 @@ base::ListValue* ToList(base::Value* val) {
}
scoped_refptr<Extension> CreateEmptyExtension() {
- return CreateEmptyExtensionWithLocation(Extension::INTERNAL);
+ return CreateEmptyExtensionWithLocation(Manifest::INTERNAL);
}
scoped_refptr<Extension> CreateEmptyExtensionWithLocation(
- Extension::Location location) {
+ Manifest::Location location) {
scoped_ptr<base::DictionaryValue> test_extension_value(
ParseDictionary("{\"name\": \"Test\", \"version\": \"1.0\"}"));
return CreateExtension(location, test_extension_value.get(), std::string());
@@ -116,18 +118,18 @@ scoped_refptr<Extension> CreateEmptyExtension(
const std::string& id_input) {
scoped_ptr<base::DictionaryValue> test_extension_value(
ParseDictionary("{\"name\": \"Test\", \"version\": \"1.0\"}"));
- return CreateExtension(Extension::INTERNAL, test_extension_value.get(),
+ return CreateExtension(Manifest::INTERNAL, test_extension_value.get(),
id_input);
}
scoped_refptr<Extension> CreateExtension(
base::DictionaryValue* test_extension_value) {
- return CreateExtension(Extension::INTERNAL, test_extension_value,
+ return CreateExtension(Manifest::INTERNAL, test_extension_value,
std::string());
}
scoped_refptr<Extension> CreateExtension(
- Extension::Location location,
+ Manifest::Location location,
base::DictionaryValue* test_extension_value,
const std::string& id_input) {
std::string error;

Powered by Google App Engine
This is Rietveld 408576698