Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1409)

Unified Diff: chrome/browser/extensions/extension_browsertest.cc

Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_browsertest.cc
diff --git a/chrome/browser/extensions/extension_browsertest.cc b/chrome/browser/extensions/extension_browsertest.cc
index f7aba1954f82790d9e2e2dbf78dd7a2fc33e2448..34a4c14599b9bc8bc717e09f5861d9439a873049 100644
--- a/chrome/browser/extensions/extension_browsertest.cc
+++ b/chrome/browser/extensions/extension_browsertest.cc
@@ -47,6 +47,7 @@
using extensions::Extension;
using extensions::ExtensionCreator;
using extensions::FeatureSwitch;
+using extensions::Manifest;
ExtensionBrowserTest::ExtensionBrowserTest()
: loaded_(false),
@@ -112,14 +113,14 @@ const Extension* ExtensionBrowserTest::LoadExtensionWithFlags(
return NULL;
if (!(flags & kFlagIgnoreManifestWarnings)) {
- const Extension::InstallWarningVector& install_warnings =
+ const extensions::InstallWarning::Vector& install_warnings =
extension->install_warnings();
if (!install_warnings.empty()) {
std::string install_warnings_message = StringPrintf(
"Unexpected warnings when loading test extension %s:\n",
path.AsUTF8Unsafe().c_str());
- for (Extension::InstallWarningVector::const_iterator it =
+ for (extensions::InstallWarning::Vector::const_iterator it =
install_warnings.begin(); it != install_warnings.end(); ++it) {
install_warnings_message += " " + it->message + "\n";
}
@@ -296,7 +297,7 @@ const Extension* ExtensionBrowserTest::InstallExtensionFromWebstore(
const FilePath& path,
int expected_change) {
return InstallOrUpdateExtension("", path, INSTALL_UI_TYPE_NONE,
- expected_change, Extension::INTERNAL,
+ expected_change, Manifest::INTERNAL,
browser(), true);
}
@@ -306,7 +307,7 @@ const Extension* ExtensionBrowserTest::InstallOrUpdateExtension(
InstallUIType ui_type,
int expected_change) {
return InstallOrUpdateExtension(id, path, ui_type, expected_change,
- Extension::INTERNAL, browser(), false);
+ Manifest::INTERNAL, browser(), false);
}
const Extension* ExtensionBrowserTest::InstallOrUpdateExtension(
@@ -317,7 +318,7 @@ const Extension* ExtensionBrowserTest::InstallOrUpdateExtension(
Browser* browser,
bool from_webstore) {
return InstallOrUpdateExtension(id, path, ui_type, expected_change,
- Extension::INTERNAL, browser, from_webstore);
+ Manifest::INTERNAL, browser, from_webstore);
}
const Extension* ExtensionBrowserTest::InstallOrUpdateExtension(
@@ -325,7 +326,7 @@ const Extension* ExtensionBrowserTest::InstallOrUpdateExtension(
const FilePath& path,
InstallUIType ui_type,
int expected_change,
- Extension::Location install_source) {
+ Manifest::Location install_source) {
return InstallOrUpdateExtension(id, path, ui_type, expected_change,
install_source, browser(), false);
}
@@ -335,7 +336,7 @@ const Extension* ExtensionBrowserTest::InstallOrUpdateExtension(
const FilePath& path,
InstallUIType ui_type,
int expected_change,
- Extension::Location install_source,
+ Manifest::Location install_source,
Browser* browser,
bool from_webstore) {
ExtensionService* service = browser->profile()->GetExtensionService();

Powered by Google App Engine
This is Rietveld 408576698