Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_chromepermission_unittest.cc

Issue 12093036: Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
6 6
7 #include "chrome/common/extensions/extension.h" 7 #include "chrome/common/extensions/extension.h"
8 #include "chrome/common/extensions/extension_manifest_constants.h" 8 #include "chrome/common/extensions/extension_manifest_constants.h"
9 #include "chrome/common/extensions/manifest.h"
9 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
10 11
11 namespace errors = extension_manifest_errors; 12 namespace errors = extension_manifest_errors;
12 13
13 TEST_F(ExtensionManifestTest, ChromeURLPermissionInvalid) { 14 TEST_F(ExtensionManifestTest, ChromeURLPermissionInvalid) {
14 LoadAndExpectError("permission_chrome_url_invalid.json", 15 LoadAndExpectError("permission_chrome_url_invalid.json",
15 errors::kInvalidPermissionScheme); 16 errors::kInvalidPermissionScheme);
16 } 17 }
17 18
18 TEST_F(ExtensionManifestTest, ChromeResourcesPermissionValidOnlyForComponents) { 19 TEST_F(ExtensionManifestTest, ChromeResourcesPermissionValidOnlyForComponents) {
19 LoadAndExpectError("permission_chrome_resources_url.json", 20 LoadAndExpectError("permission_chrome_resources_url.json",
20 errors::kInvalidPermissionScheme); 21 errors::kInvalidPermissionScheme);
21 std::string error; 22 std::string error;
22 LoadExtension(Manifest("permission_chrome_resources_url.json"), 23 LoadExtension(Manifest("permission_chrome_resources_url.json"),
23 &error, extensions::Extension::COMPONENT, 24 &error, extensions::Manifest::COMPONENT,
24 extensions::Extension::NO_FLAGS); 25 extensions::Extension::NO_FLAGS);
25 EXPECT_EQ("", error); 26 EXPECT_EQ("", error);
26 } 27 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698