Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file.

chrome/common/extensions/extension_l10n_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/linked_ptr.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
 #include "base/values.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_l10n_util.h"
 #include "chrome/common/extensions/extension_manifest_constants.h"
 #include "chrome/common/extensions/message_bundle.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/l10n/l10n_util.h"
 
 using extensions::Extension;
 using extensions::ExtensionInfo;
+using extensions::Manifest;
 using extensions::MessageBundle;
 
 namespace errors = extension_manifest_errors;
 namespace keys = extension_manifest_keys;
 
 namespace {
 
 // crbug.com/108429: Crashing on Windows Vista bots.
 #if defined(OS_WIN)
 #define GetValidLocalesEmptyLocaleFolder \
@@ skipping 521 matching lines @@
   EXPECT_EQ("description", result);
 
   ASSERT_TRUE(handler->GetString(keys::kPageActionDefaultTitle, &result));
   EXPECT_EQ("file handler title", result);
 
   EXPECT_TRUE(error.empty());
 }
 
 // Try with NULL manifest.
 TEST(ExtensionL10nUtil, ShouldRelocalizeManifestWithNullManifest) {
-  ExtensionInfo info(NULL, "", FilePath(), Extension::LOAD);
+  ExtensionInfo info(NULL, "", FilePath(), Manifest::LOAD);
 
   EXPECT_FALSE(extension_l10n_util::ShouldRelocalizeManifest(info));
 }
 
 // Try with default and current locales missing.
 TEST(ExtensionL10nUtil, ShouldRelocalizeManifestEmptyManifest) {
   DictionaryValue manifest;
-  ExtensionInfo info(&manifest, "", FilePath(), Extension::LOAD);
+  ExtensionInfo info(&manifest, "", FilePath(), Manifest::LOAD);
 
   EXPECT_FALSE(extension_l10n_util::ShouldRelocalizeManifest(info));
 }
 
 // Try with missing current_locale.
 TEST(ExtensionL10nUtil, ShouldRelocalizeManifestWithDefaultLocale) {
   DictionaryValue manifest;
   manifest.SetString(keys::kDefaultLocale, "en_US");
 
-  ExtensionInfo info(&manifest, "", FilePath(), Extension::LOAD);
+  ExtensionInfo info(&manifest, "", FilePath(), Manifest::LOAD);
 
   EXPECT_TRUE(extension_l10n_util::ShouldRelocalizeManifest(info));
 }
 
 // Try with missing default_locale.
 TEST(ExtensionL10nUtil, ShouldRelocalizeManifestWithCurrentLocale) {
   DictionaryValue manifest;
   manifest.SetString(keys::kCurrentLocale,
                      extension_l10n_util::CurrentLocaleOrDefault());
 
-  ExtensionInfo info(&manifest, "", FilePath(), Extension::LOAD);
+  ExtensionInfo info(&manifest, "", FilePath(), Manifest::LOAD);
 
   EXPECT_FALSE(extension_l10n_util::ShouldRelocalizeManifest(info));
 }
 
 // Try with all data present, but with same current_locale as system locale.
 TEST(ExtensionL10nUtil, ShouldRelocalizeManifestSameCurrentLocale) {
   DictionaryValue manifest;
   manifest.SetString(keys::kDefaultLocale, "en_US");
   manifest.SetString(keys::kCurrentLocale,
                      extension_l10n_util::CurrentLocaleOrDefault());
 
-  ExtensionInfo info(&manifest, "", FilePath(), Extension::LOAD);
+  ExtensionInfo info(&manifest, "", FilePath(), Manifest::LOAD);
 
   EXPECT_FALSE(extension_l10n_util::ShouldRelocalizeManifest(info));
 }
 
 // Try with all data present, but with different current_locale.
 TEST(ExtensionL10nUtil, ShouldRelocalizeManifestDifferentCurrentLocale) {
   DictionaryValue manifest;
   manifest.SetString(keys::kDefaultLocale, "en_US");
   manifest.SetString(keys::kCurrentLocale, "sr");
 
-  ExtensionInfo info(&manifest, "", FilePath(), Extension::LOAD);
+  ExtensionInfo info(&manifest, "", FilePath(), Manifest::LOAD);
 
   EXPECT_TRUE(extension_l10n_util::ShouldRelocalizeManifest(info));
 }
 
 TEST(ExtensionL10nUtil, GetAllFallbackLocales) {
   std::vector<std::string> fallback_locales;
   extension_l10n_util::GetAllFallbackLocales("en_US", "all", &fallback_locales);
   ASSERT_EQ(3U, fallback_locales.size());
 
   CHECK_EQ("en_US", fallback_locales[0]);
   CHECK_EQ("en", fallback_locales[1]);
   CHECK_EQ("all", fallback_locales[2]);
 }
 
 }  // namespace