Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file.

chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 15 matching lines @@
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/browser_with_test_window_test.h"
 #include "chrome/test/base/testing_pref_service.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/test/test_browser_thread.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/models/menu_model.h"
 
 using extensions::Extension;
+using extensions::Manifest;
 
 namespace {
 const int kExpectedAppIndex = 1;
 const char* gmail_app_id = "pjkljhegncpnkpknbcohdijeoejaedia";
 const char* gmail_url = "https://mail.google.com/mail/u";
 }
 
 class ChromeLauncherControllerPerAppTest : public BrowserWithTestWindowTest {
  protected:
   ChromeLauncherControllerPerAppTest() : extension_service_(NULL) {
   }
 
   virtual void SetUp() OVERRIDE {
     BrowserWithTestWindowTest::SetUp();
 
     DictionaryValue manifest;
     manifest.SetString("name", "launcher controller test extension");
     manifest.SetString("version", "1");
     manifest.SetString("description", "for testing pinned apps");
 
     extensions::TestExtensionSystem* extension_system(
         static_cast<extensions::TestExtensionSystem*>(
             extensions::ExtensionSystem::Get(profile())));
     extension_service_ = extension_system->CreateExtensionService(
         CommandLine::ForCurrentProcess(), FilePath(), false);
 
     std::string error;
-    extension1_ = Extension::Create(FilePath(), Extension::LOAD, manifest,
+    extension1_ = Extension::Create(FilePath(), Manifest::LOAD, manifest,
                                     Extension::NO_FLAGS,
                                     "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
                                     &error);
-    extension2_ = Extension::Create(FilePath(), Extension::LOAD, manifest,
+    extension2_ = Extension::Create(FilePath(), Manifest::LOAD, manifest,
                                     Extension::NO_FLAGS,
                                     "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb",
                                     &error);
     // Fake gmail extension.
-    extension3_ = Extension::Create(FilePath(), Extension::LOAD, manifest,
+    extension3_ = Extension::Create(FilePath(), Manifest::LOAD, manifest,
                                     Extension::NO_FLAGS,
                                     gmail_app_id,
                                     &error);
 
     // Fake search extension.
-    extension4_ = Extension::Create(FilePath(), Extension::LOAD, manifest,
+    extension4_ = Extension::Create(FilePath(), Manifest::LOAD, manifest,
                                     Extension::NO_FLAGS,
                                     "coobgpohoikkiipiblmjeljniedjpjpf",
                                     &error);
   }
 
   void InsertPrefValue(base::ListValue* pref_value,
                        int index,
                        const std::string& extension_id) {
     base::DictionaryValue* entry = new DictionaryValue();
     entry->SetString(ash::kPinnedAppsPrefAppIDPath, extension_id);
@@ skipping 377 matching lines @@
     int first_item =
         (menu->GetTypeAt(0) == ui::MenuModel::TYPE_SEPARATOR) ? 1 : 0;
     menu->ActivatedAt(first_item + 3);
   }
   // Now the active tab should be the second item.
   EXPECT_EQ(0, browser()->tab_strip_model()->active_index());
 }
 
 // TODO(skuhne) Add tests for:
 //   - V2 apps: create through item in launcher or directly