Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file.

chrome/browser/extensions/api/management/management_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/management/management_api.h"
 
 #include <map>
 #include <string>
 #include <vector>
 
@@ skipping 156 matching lines @@
         extension.GetActivePermissions()->explicit_hosts();
     if (!host_perms.is_empty()) {
       for (URLPatternSet::const_iterator iter = host_perms.begin();
            iter != host_perms.end(); ++iter) {
         info->host_permissions.push_back(iter->GetAsString());
       }
     }
   }
 
   switch (extension.location()) {
-    case Extension::INTERNAL:
+    case Manifest::INTERNAL:
       info->install_type = management::ExtensionInfo::INSTALL_TYPE_NORMAL;
       break;
-    case Extension::LOAD:
+    case Manifest::LOAD:
       info->install_type = management::ExtensionInfo::INSTALL_TYPE_DEVELOPMENT;
       break;
-    case Extension::EXTERNAL_PREF:
-    case Extension::EXTERNAL_REGISTRY:
-    case Extension::EXTERNAL_PREF_DOWNLOAD:
+    case Manifest::EXTERNAL_PREF:
+    case Manifest::EXTERNAL_REGISTRY:
+    case Manifest::EXTERNAL_PREF_DOWNLOAD:
       info->install_type = management::ExtensionInfo::INSTALL_TYPE_SIDELOAD;
       break;
-    case Extension::EXTERNAL_POLICY_DOWNLOAD:
+    case Manifest::EXTERNAL_POLICY_DOWNLOAD:
       info->install_type = management::ExtensionInfo::INSTALL_TYPE_ADMIN;
       break;
     default:
       info->install_type = management::ExtensionInfo::INSTALL_TYPE_OTHER;
       break;
   }
 
   return info.Pass();
 }
 
 void AddExtensionInfo(const ExtensionSet& extensions,
                             ExtensionSystem* system,
                             ExtensionInfoList* extension_list) {
   for (ExtensionSet::const_iterator iter = extensions.begin();
        iter != extensions.end(); ++iter) {
     const Extension& extension = **iter;
 
-    if (extension.location() == Extension::COMPONENT)
+    if (extension.location() == Manifest::COMPONENT)
       continue;  // Skip built-in extensions.
 
     extension_list->push_back(make_linked_ptr<management::ExtensionInfo>(
         CreateExtensionInfo(extension, system).release()));
   }
 }
 
 } // namespace
 
 ExtensionService* ManagementFunction::service() {
@@ skipping 158 matching lines @@
 
   // Response is sent async in OnParseSuccess/Failure().
   return true;
 }
 
 void ManagementGetPermissionWarningsByManifestFunction::OnParseSuccess(
     DictionaryValue* parsed_manifest) {
   CHECK(parsed_manifest);
 
   scoped_refptr<Extension> extension = Extension::Create(
-      FilePath(), Extension::INVALID, *parsed_manifest, Extension::NO_FLAGS,
-      &error_);
+      FilePath(), Manifest::INVALID_LOCATION, *parsed_manifest,
+      Extension::NO_FLAGS, &error_);
   if (!extension.get()) {
     OnParseFailure(keys::kExtensionCreateError);
     return;
   }
 
   std::vector<std::string> warnings = CreateWarningsList(extension);
   results_ = management::GetPermissionWarningsByManifest::Results::Create(
       warnings);
   SendResponse(true);
 
@@ skipping 282 matching lines @@
 ProfileKeyedAPIFactory<ManagementAPI>* ManagementAPI::GetFactoryInstance() {
   return &g_factory.Get();
 }
 
 void ManagementAPI::OnListenerAdded(const EventListenerInfo& details) {
   management_event_router_.reset(new ManagementEventRouter(profile_));
   ExtensionSystem::Get(profile_)->event_router()->UnregisterObserver(this);
 }
 
 }  // namespace extensions