Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file.

chrome/browser/extensions/api/alarms/alarms_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/alarms/alarms_api.h"
 
 #include "base/string_number_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/api/alarms/alarm_manager.h"
 #include "chrome/browser/extensions/extension_system.h"
@@ skipping 34 matching lines @@
 
   // Users can always use an absolute timeout to request an arbitrarily-short or
   // negative delay.  We won't honor the short timeout, but we can't check it
   // and warn the user because it would introduce race conditions (say they
   // compute a long-enough timeout, but then the call into the alarms interface
   // gets delayed past the boundary).  However, it's still worth warning about
   // relative delays that are shorter than we'll honor.
   if (create_info.delay_in_minutes.get()) {
     if (*create_info.delay_in_minutes < kReleaseDelayMinimum) {
       COMPILE_ASSERT(kReleaseDelayMinimum == 1, update_warning_message_below);
-      if (extension->location() == Extension::LOAD)
+      if (extension->location() == Manifest::LOAD)
         warnings->push_back(ErrorUtils::FormatErrorMessage(
             "Alarm delay is less than minimum of 1 minutes."
             " In released .crx, alarm \"*\" will fire in approximately"
             " 1 minutes.",
             alarm_name));
       else
         warnings->push_back(ErrorUtils::FormatErrorMessage(
             "Alarm delay is less than minimum of 1 minutes."
             " Alarm \"*\" will fire in approximately 1 minutes.",
             alarm_name));
     }
   }
   if (create_info.period_in_minutes.get()) {
     if (*create_info.period_in_minutes < kReleaseDelayMinimum) {
       COMPILE_ASSERT(kReleaseDelayMinimum == 1, update_warning_message_below);
-      if (extension->location() == Extension::LOAD)
+      if (extension->location() == Manifest::LOAD)
         warnings->push_back(ErrorUtils::FormatErrorMessage(
             "Alarm period is less than minimum of 1 minutes."
             " In released .crx, alarm \"*\" will fire approximately"
             " every 1 minutes.",
             alarm_name));
       else
         warnings->push_back(ErrorUtils::FormatErrorMessage(
             "Alarm period is less than minimum of 1 minutes."
             " Alarm \"*\" will fire approximately every 1 minutes.",
             alarm_name));
@@ skipping 19 matching lines @@
   if (!ValidateAlarmCreateInfo(
           alarm_name, params->alarm_info, GetExtension(), &error_, &warnings))
     return false;
   for (std::vector<std::string>::const_iterator it = warnings.begin();
        it != warnings.end(); ++it)
     WriteToConsole(content::CONSOLE_MESSAGE_LEVEL_WARNING, *it);
 
   Alarm alarm(alarm_name,
               params->alarm_info,
               base::TimeDelta::FromMinutes(
-                  GetExtension()->location() == Extension::LOAD ?
+                  GetExtension()->location() == Manifest::LOAD ?
                   kDevDelayMinimum : kReleaseDelayMinimum),
               now_);
   ExtensionSystem::Get(profile())->alarm_manager()->AddAlarm(
       extension_id(), alarm);
 
   return true;
 }
 
 bool AlarmsGetFunction::RunImpl() {
   scoped_ptr<alarms::Get::Params> params(alarms::Get::Params::Create(*args_));
@@ skipping 47 matching lines @@
   return true;
 }
 
 bool AlarmsClearAllFunction::RunImpl() {
   ExtensionSystem::Get(profile())->alarm_manager()->RemoveAllAlarms(
      extension_id());
   return true;
 }
 
 }  // namespace extensions