Move Extension Location and Type enums to Manifest, and move InstallWarning to its own file.

chrome/browser/extensions/external_policy_loader_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <set>
 #include <string>
 
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/values.h"
 #include "base/version.h"
 #include "chrome/browser/extensions/external_policy_loader.h"
 #include "chrome/browser/extensions/external_provider_impl.h"
 #include "chrome/browser/extensions/external_provider_interface.h"
 #include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/manifest.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/testing_pref_service.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/test/test_browser_thread.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using content::BrowserThread;
 
 namespace extensions {
 
@@ skipping 23 matching lines @@
   // exactly the extensions specified in |expected_extensions|.
   void Visit(const base::DictionaryValue& policy_forcelist,
              const std::set<std::string>& expected_extensions) {
     profile_.reset(new TestingProfile);
     profile_->GetTestingPrefService()->SetManagedPref(
         prefs::kExtensionInstallForceList,
         policy_forcelist.DeepCopy());
     provider_.reset(new ExternalProviderImpl(
         this,
         new ExternalPolicyLoader(profile_.get()),
-        Extension::INVALID,
-        Extension::EXTERNAL_POLICY_DOWNLOAD,
+        Manifest::INVALID_LOCATION,
+        Manifest::EXTERNAL_POLICY_DOWNLOAD,
         Extension::NO_FLAGS));
 
     // Extensions will be removed from this list as they visited,
     // so it should be emptied by the end.
     expected_extensions_ = expected_extensions;
     provider_->VisitRegisteredExtension();
     EXPECT_TRUE(expected_extensions_.empty());
   }
 
   virtual bool OnExternalExtensionFileFound(const std::string& id,
                                             const Version* version,
                                             const FilePath& path,
-                                            Extension::Location unused,
+                                            Manifest::Location unused,
                                             int unused2,
                                             bool unused3) {
     ADD_FAILURE() << "There should be no external extensions from files.";
     return false;
   }
 
   virtual bool OnExternalExtensionUpdateUrlFound(
       const std::string& id, const GURL& update_url,
-      Extension::Location location) {
+      Manifest::Location location) {
     // Extension has the correct location.
-    EXPECT_EQ(Extension::EXTERNAL_POLICY_DOWNLOAD, location);
+    EXPECT_EQ(Manifest::EXTERNAL_POLICY_DOWNLOAD, location);
 
     // Provider returns the correct location when asked.
-    Extension::Location location1;
+    Manifest::Location location1;
     scoped_ptr<Version> version1;
     provider_->GetExtensionDetails(id, &location1, &version1);
-    EXPECT_EQ(Extension::EXTERNAL_POLICY_DOWNLOAD, location1);
+    EXPECT_EQ(Manifest::EXTERNAL_POLICY_DOWNLOAD, location1);
     EXPECT_FALSE(version1.get());
 
     // Remove the extension from our list.
     EXPECT_EQ(1U, expected_extensions_.erase(id));
     return true;
   }
 
   virtual void OnExternalProviderReady(
       const ExternalProviderInterface* provider) {
     EXPECT_EQ(provider, provider_.get());
@@ skipping 38 matching lines @@
   // Add invalid entries.
   forced_extensions.SetString("invalid", "http://www.example.com/crx");
   forced_extensions.SetString("dddddddddddddddddddddddddddddddd", "");
   forced_extensions.SetString("invalid", "bad");
 
   MockExternalPolicyProviderVisitor mv;
   mv.Visit(forced_extensions, expected_extensions);
 }
 
 }  // namespace extensions