Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: net/proxy/proxy_resolver_v8.h

Issue 12092098: Make an interface's virtual dtor protected rather than public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_resolver_v8.h
diff --git a/net/proxy/proxy_resolver_v8.h b/net/proxy/proxy_resolver_v8.h
index a310460144768f7ad5e2b71b04143f6281ffb300..823e93a08cde9c70c70e02df077f34c624a1cac9 100644
--- a/net/proxy/proxy_resolver_v8.h
+++ b/net/proxy/proxy_resolver_v8.h
@@ -45,8 +45,6 @@ class NET_EXPORT_PRIVATE ProxyResolverV8 : public ProxyResolver {
JSBindings() {}
- virtual ~JSBindings() {}
-
// Handler for "dnsResolve()", "dnsResolveEx()", "myIpAddress()",
// "myIpAddressEx()". Returns true on success and fills |*output| with the
// result.
@@ -60,6 +58,9 @@ class NET_EXPORT_PRIVATE ProxyResolverV8 : public ProxyResolver {
// Handler for when an error is encountered. |line_number| may be -1
// if a line number is not applicable to this error.
virtual void OnError(int line_number, const string16& error) = 0;
+
+ protected:
+ virtual ~JSBindings() {}
};
// Constructs a ProxyResolverV8.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698