Issue 12092098: Make an interface's virtual dtor protected rather than public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12092098: Make an interface's virtual dtor protected rather than public. (Closed)

Created:
7 years, 10 months ago by eroman

Modified:
7 years, 10 months ago

Reviewers:
Ryan Sleevi

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make an interface's virtual dtor protected rather than public. This avoid a warning in chromium's clang plugin, since ProxyResolverV8Tracing::Job is refcounted and implements this interface. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180066

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	net/proxy/proxy_resolver_v8.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/12092098/1

7 years, 10 months ago (2013-02-01 00:48:59 UTC) #3

Message was sent while issue was closed.

Change committed as 180066

Expand Messages | Collapse Messages