Remove 'content' dependency from device/media_transfer_protocol

Remove 'content' dependency from device/media_transfer_protocol.

BUG=171742
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180065

[Lei Zhang, 2013-01-31 04:01:31]

Don't you need to rebase this on top of
https://codereview.chromium.org/12082017/ or vice versa?

https://codereview.chromium.org/12092074/diff/10002/device/media_transfer_pro...
File device/media_transfer_protocol/media_transfer_protocol_manager.cc (right):

https://codereview.chromium.org/12092074/diff/10002/device/media_transfer_pro...
device/media_transfer_protocol/media_transfer_protocol_manager.cc:447:
g_media_transfer_protocol_manager = new MediaTransferProtocolManagerImpl(
nit: I find it a bit more readable if you wrap the second line after '=', since
you use two lines either way.

https://codereview.chromium.org/12092074/diff/10002/device/media_transfer_pro...
File device/media_transfer_protocol/media_transfer_protocol_manager.h (right):

https://codereview.chromium.org/12092074/diff/10002/device/media_transfer_pro...
device/media_transfer_protocol/media_transfer_protocol_manager.h:136: static
void Initialize(scoped_refptr<base::MessageLoopProxy> loop_proxy);
Document |loop_proxy|.

[kmadhusu, 2013-01-31 18:12:38]

https://codereview.chromium.org/12082017/ is in CQ. I will rebase this CL once
that change lands.

https://codereview.chromium.org/12092074/diff/10002/device/media_transfer_pro...
File device/media_transfer_protocol/media_transfer_protocol_manager.cc (right):

https://codereview.chromium.org/12092074/diff/10002/device/media_transfer_pro...
device/media_transfer_protocol/media_transfer_protocol_manager.cc:447:
g_media_transfer_protocol_manager = new MediaTransferProtocolManagerImpl(
On 2013/01/31 04:01:31, Lei Zhang wrote:
> nit: I find it a bit more readable if you wrap the second line after '=',
since
> you use two lines either way.

Done.

https://codereview.chromium.org/12092074/diff/10002/device/media_transfer_pro...
File device/media_transfer_protocol/media_transfer_protocol_manager.h (right):

https://codereview.chromium.org/12092074/diff/10002/device/media_transfer_pro...
device/media_transfer_protocol/media_transfer_protocol_manager.h:136: static
void Initialize(scoped_refptr<base::MessageLoopProxy> loop_proxy);
On 2013/01/31 04:01:31, Lei Zhang wrote:
> Document |loop_proxy|.

Done.

[Lei Zhang, 2013-01-31 20:56:37]

lgtm

https://codereview.chromium.org/12092074/diff/11003/device/media_transfer_pro...
File device/media_transfer_protocol/media_transfer_protocol_manager.h (right):

https://codereview.chromium.org/12092074/diff/11003/device/media_transfer_pro...
device/media_transfer_protocol/media_transfer_protocol_manager.h:136: // On
Linux, |loop_proxy| specifies the Bus object message loop proxy
Someone reading the header won't know what Bus object you are talking about.
Just omit that bit.

https://codereview.chromium.org/12092074/diff/11003/device/media_transfer_pro...
device/media_transfer_protocol/media_transfer_protocol_manager.h:138: // On
ChromeOS, |loop_proxy| is set to NULL.
... set to NULL because ChromeOS already has a dedicated message loop proxy.

[kmadhusu, 2013-01-31 22:07:59]

https://codereview.chromium.org/12092074/diff/11003/device/media_transfer_pro...
File device/media_transfer_protocol/media_transfer_protocol_manager.h (right):

https://codereview.chromium.org/12092074/diff/11003/device/media_transfer_pro...
device/media_transfer_protocol/media_transfer_protocol_manager.h:136: // On
Linux, |loop_proxy| specifies the Bus object message loop proxy
On 2013/01/31 20:56:38, Lei Zhang wrote:
> Someone reading the header won't know what Bus object you are talking about.
> Just omit that bit.

Done.

https://codereview.chromium.org/12092074/diff/11003/device/media_transfer_pro...
device/media_transfer_protocol/media_transfer_protocol_manager.h:138: // On
ChromeOS, |loop_proxy| is set to NULL.
On 2013/01/31 20:56:38, Lei Zhang wrote:
> ... set to NULL because ChromeOS already has a dedicated message loop proxy.

Done.

[kmadhusu, 2013-01-31 22:09:31]

miket@: Can you do the OWNER's check for device/* changes?

Thanks.

[miket_OOO, 2013-01-31 22:54:07]

lgtm

[commit-bot: I haz the power, 2013-01-31 23:18:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/12092074/15001

[commit-bot: I haz the power, 2013-02-01 03:53:58]

Change committed as 180065