Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 12092068: Get rid of vista_winnt (Closed)

Created:
7 years, 10 months ago by mnaganov (inactive)
Modified:
7 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[RLZ] Get rid of vista_winnt.h This file was needed for compiling on pre-Vista SDKs. Since now Chromium requires at least Windows 7 SDK, it should not be needed anymore. BUG=172607 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -101 lines) Patch
M rlz/rlz.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M rlz/win/lib/process_info.cc View 1 chunk +0 lines, -1 line 0 comments Download
D rlz/win/lib/vista_winnt.h View 1 chunk +0 lines, -99 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mnaganov (inactive)
Roger, Nico, please take a look. Some of trybots are red, but this is due ...
7 years, 10 months ago (2013-01-30 21:34:29 UTC) #1
Nico
I'll defer to Roger. This predates my involvement in rlz, and I only worked on ...
7 years, 10 months ago (2013-01-30 21:36:48 UTC) #2
mnaganov (inactive)
Is Rodger actually in town?
7 years, 10 months ago (2013-02-01 09:13:59 UTC) #3
Roger Tawa OOO till Jul 10th
lgtm Sorry for delay, I thought I had lgtm'ed yesterday.
7 years, 10 months ago (2013-02-01 15:15:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/12092068/1
7 years, 10 months ago (2013-02-01 15:17:00 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=106368
7 years, 10 months ago (2013-02-01 21:44:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/12092068/1
7 years, 10 months ago (2013-02-02 22:39:12 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=107249
7 years, 10 months ago (2013-02-03 01:55:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/12092068/1
7 years, 10 months ago (2013-02-03 03:56:56 UTC) #9
commit-bot: I haz the power
7 years, 10 months ago (2013-02-03 05:12:14 UTC) #10
Message was sent while issue was closed.
Change committed as 180289

Powered by Google App Engine
This is Rietveld 408576698