Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 12092063: Also allow the empty object map to keep transitions. (Closed)

Created:
7 years, 10 months ago by Toon Verwaest
Modified:
7 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Also allow the empty object map to keep transitions. With the old implementation, due to the map-check being inadequate, such transitions were already added for cross-context field stores. It is not necessary anymore to not store transitions, since we properly clear non-live transitions. Globally enabling this feature will help find more bugs. BUG=v8:2518 R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=13558

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -21 lines) Patch
M src/isolate.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/objects.cc View 1 4 chunks +5 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 10 months ago (2013-01-30 09:05:28 UTC) #1
Michael Starzinger
LGTM (with one nit). https://chromiumcodereview.appspot.com/12092063/diff/1/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/12092063/diff/1/src/objects.cc#newcode1838 src/objects.cc:1838: // with the map of ...
7 years, 10 months ago (2013-01-30 10:37:15 UTC) #2
Toon Verwaest
7 years, 10 months ago (2013-01-30 15:07:10 UTC) #3
Addressed comment, landing.

Powered by Google App Engine
This is Rietveld 408576698