dbus/object_proxy.h - Issue 12092061: Code cleaning: Uses scoped_ptr<> to express ownership rather than writing ownership in comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dbus/object_proxy.h

Issue 12092061: Code cleaning: Uses scoped_ptr<> to express ownership rather than writing ownership in comments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added chrome/browser/password_manager/native_backend_kwallet_x_unitte\ Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dbus/object_proxy.h

diff --git a/dbus/object_proxy.h b/dbus/object_proxy.h

index 801c57753fb18ee3064bd21cfb9b9900dac35586..61576e6b73a7cb30f7255db2e3520a2c936bfd31 100644

--- a/dbus/object_proxy.h

+++ b/dbus/object_proxy.h

@@ -81,11 +81,10 @@ class CHROME_DBUS_EXPORT ObjectProxy

// Calls the method of the remote object and blocks until the response

// is returned. Returns NULL on error.

- // The caller is responsible to delete the returned object.

// BLOCKING CALL.

- virtual Response* CallMethodAndBlock(MethodCall* method_call,

- int timeout_ms);

+ virtual scoped_ptr<Response> CallMethodAndBlock(MethodCall* method_call,

+ int timeout_ms);

// Requests to call the method of the remote object.

« no previous file with comments | « dbus/mock_unittest.cc ('k') | dbus/object_proxy.cc » ('j') | no next file with comments »