Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: chromeos/dbus/ibus/ibus_engine_factory_service.cc

Issue 12092061: Code cleaning: Uses scoped_ptr<> to express ownership rather than writing ownership in comments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added chrome/browser/password_manager/native_backend_kwallet_x_unitte\ Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/ibus/ibus_engine_factory_service.cc
diff --git a/chromeos/dbus/ibus/ibus_engine_factory_service.cc b/chromeos/dbus/ibus/ibus_engine_factory_service.cc
index 936b54f27dc1533c5ae4cc9da2ef48bcf32eca9e..49ca041b976ce486e81b796facf695c29e59e7d6 100644
--- a/chromeos/dbus/ibus/ibus_engine_factory_service.cc
+++ b/chromeos/dbus/ibus/ibus_engine_factory_service.cc
@@ -73,19 +73,19 @@ class IBusEngineFactoryServiceImpl : public IBusEngineFactoryService {
create_engine_callback_map_[engine_name].Run(
base::Bind(&IBusEngineFactoryServiceImpl::CreateEngineSendReply,
weak_ptr_factory_.GetWeakPtr(),
- dbus::Response::FromMethodCall(method_call),
+ base::Passed(dbus::Response::FromMethodCall(method_call)),
response_sender));
}
}
// Sends reply message for CreateEngine method call.
void CreateEngineSendReply(
- dbus::Response* response,
+ scoped_ptr<dbus::Response> response,
const dbus::ExportedObject::ResponseSender response_sender,
const dbus::ObjectPath& path) {
- dbus::MessageWriter writer(response);
+ dbus::MessageWriter writer(response.get());
writer.AppendObjectPath(path);
- response_sender.Run(response);
+ response_sender.Run(response.Pass());
}
// Called when the CreateEngine method is exported.
« no previous file with comments | « chromeos/dbus/bluetooth_agent_service_provider.cc ('k') | chromeos/dbus/ibus/ibus_engine_factory_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698