Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: chromeos/dbus/blocking_method_caller.h

Issue 12092061: Code cleaning: Uses scoped_ptr<> to express ownership rather than writing ownership in comments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added chrome/browser/password_manager/native_backend_kwallet_x_unitte\ Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/blocking_method_caller.h
diff --git a/chromeos/dbus/blocking_method_caller.h b/chromeos/dbus/blocking_method_caller.h
index 95aa44041a99697c6674eb38c6638e56db7295ac..6291f47c030b9249d6ae21ad438e486a70a82559 100644
--- a/chromeos/dbus/blocking_method_caller.h
+++ b/chromeos/dbus/blocking_method_caller.h
@@ -8,13 +8,12 @@
#include "base/callback.h"
#include "base/synchronization/waitable_event.h"
#include "chromeos/chromeos_export.h"
+#include "dbus/message.h"
namespace dbus {
class Bus;
class ObjectProxy;
-class MethodCall;
-class Response;
} // namespace dbus
@@ -29,8 +28,7 @@ class CHROMEOS_EXPORT BlockingMethodCaller {
virtual ~BlockingMethodCaller();
// Calls the method and blocks until it returns.
- // The caller is responsible to delete the returned object.
- dbus::Response* CallMethodAndBlock(dbus::MethodCall* method_call);
+ scoped_ptr<dbus::Response> CallMethodAndBlock(dbus::MethodCall* method_call);
private:
dbus::Bus* bus_;
« no previous file with comments | « chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc ('k') | chromeos/dbus/blocking_method_caller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698