Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: chrome/browser/chromeos/dbus/service_provider_test_helper.cc

Issue 12092061: Code cleaning: Uses scoped_ptr<> to express ownership rather than writing ownership in comments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added chrome/browser/password_manager/native_backend_kwallet_x_unitte\ Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/dbus/service_provider_test_helper.h" 5 #include "chrome/browser/chromeos/dbus/service_provider_test_helper.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "dbus/message.h" 8 #include "dbus/message.h"
9 #include "dbus/mock_bus.h" 9 #include "dbus/mock_bus.h"
10 #include "testing/gmock/include/gmock/gmock.h" 10 #include "testing/gmock/include/gmock/gmock.h"
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 ExportMethod(kLibCrosServiceInterface, 50 ExportMethod(kLibCrosServiceInterface,
51 exported_method_name, _, _)) 51 exported_method_name, _, _))
52 .WillOnce(Invoke(this, &ServiceProviderTestHelper::MockExportMethod)); 52 .WillOnce(Invoke(this, &ServiceProviderTestHelper::MockExportMethod));
53 53
54 // Create a mock object proxy, with which we call a method of 54 // Create a mock object proxy, with which we call a method of
55 // |mock_exported_object_|. 55 // |mock_exported_object_|.
56 mock_object_proxy_ = 56 mock_object_proxy_ =
57 new dbus::MockObjectProxy(mock_bus_.get(), 57 new dbus::MockObjectProxy(mock_bus_.get(),
58 kLibCrosServiceName, 58 kLibCrosServiceName,
59 dbus::ObjectPath(kLibCrosServicePath)); 59 dbus::ObjectPath(kLibCrosServicePath));
60 // |mock_object_proxy_|'s CallMethodAndBlock() will use 60 // |mock_object_proxy_|'s MockCallMethodAndBlock() will use
61 // MockCallMethodAndBlock() to return responses. 61 // MockCallMethodAndBlock() to return responses.
62 EXPECT_CALL(*mock_object_proxy_, 62 EXPECT_CALL(*mock_object_proxy_,
63 CallMethodAndBlock( 63 MockCallMethodAndBlock(
64 AllOf( 64 AllOf(
65 ResultOf( 65 ResultOf(
66 std::mem_fun(&dbus::MethodCall::GetInterface), 66 std::mem_fun(&dbus::MethodCall::GetInterface),
67 kLibCrosServiceInterface), 67 kLibCrosServiceInterface),
68 ResultOf( 68 ResultOf(
69 std::mem_fun(&dbus::MethodCall::GetMember), 69 std::mem_fun(&dbus::MethodCall::GetMember),
70 exported_method_name)), 70 exported_method_name)),
71 _)) 71 _))
72 .WillOnce(Invoke(this, 72 .WillOnce(Invoke(this,
73 &ServiceProviderTestHelper::MockCallMethodAndBlock)); 73 &ServiceProviderTestHelper::MockCallMethodAndBlock));
74 74
75 service_provider->Start(mock_exported_object_.get()); 75 service_provider->Start(mock_exported_object_.get());
76 } 76 }
77 77
78 void ServiceProviderTestHelper::TearDown() { 78 void ServiceProviderTestHelper::TearDown() {
79 mock_bus_->ShutdownAndBlock(); 79 mock_bus_->ShutdownAndBlock();
80 mock_exported_object_ = NULL; 80 mock_exported_object_ = NULL;
(...skipping 14 matching lines...) Expand all
95 // |mock_object_proxy_|'s ConnectToSignal will use 95 // |mock_object_proxy_|'s ConnectToSignal will use
96 // MockConnectToSignal(). 96 // MockConnectToSignal().
97 EXPECT_CALL(*mock_object_proxy_, 97 EXPECT_CALL(*mock_object_proxy_,
98 ConnectToSignal(interface_name, signal_name, _, _)) 98 ConnectToSignal(interface_name, signal_name, _, _))
99 .WillOnce(Invoke(this, &ServiceProviderTestHelper::MockConnectToSignal)); 99 .WillOnce(Invoke(this, &ServiceProviderTestHelper::MockConnectToSignal));
100 100
101 mock_object_proxy_->ConnectToSignal(interface_name, signal_name, 101 mock_object_proxy_->ConnectToSignal(interface_name, signal_name,
102 signal_callback, on_connected_callback); 102 signal_callback, on_connected_callback);
103 } 103 }
104 104
105 dbus::Response* ServiceProviderTestHelper::CallMethod( 105 scoped_ptr<dbus::Response> ServiceProviderTestHelper::CallMethod(
106 dbus::MethodCall* method_call) { 106 dbus::MethodCall* method_call) {
107 return mock_object_proxy_->CallMethodAndBlock(method_call, 107 return mock_object_proxy_->CallMethodAndBlock(
108 method_call,
108 dbus::ObjectProxy::TIMEOUT_USE_DEFAULT); 109 dbus::ObjectProxy::TIMEOUT_USE_DEFAULT);
109 } 110 }
110 111
111 void ServiceProviderTestHelper::MockExportMethod( 112 void ServiceProviderTestHelper::MockExportMethod(
112 const std::string& interface_name, 113 const std::string& interface_name,
113 const std::string& method_name, 114 const std::string& method_name,
114 dbus::ExportedObject::MethodCallCallback method_callback, 115 dbus::ExportedObject::MethodCallCallback method_callback,
115 dbus::ExportedObject::OnExportedCallback on_exported_callback) { 116 dbus::ExportedObject::OnExportedCallback on_exported_callback) {
116 // Tell the call back that the method is exported successfully. 117 // Tell the call back that the method is exported successfully.
117 on_exported_callback.Run(interface_name, method_name, true); 118 on_exported_callback.Run(interface_name, method_name, true);
(...skipping 30 matching lines...) Expand all
148 // Capture the callback, so we can run this at a later time. 149 // Capture the callback, so we can run this at a later time.
149 on_signal_callback_ = signal_callback; 150 on_signal_callback_ = signal_callback;
150 } 151 }
151 152
152 void ServiceProviderTestHelper::MockSendSignal(dbus::Signal* signal) { 153 void ServiceProviderTestHelper::MockSendSignal(dbus::Signal* signal) {
153 // Run the callback captured in MockConnectToSignal(). This will call 154 // Run the callback captured in MockConnectToSignal(). This will call
154 // OnSignalReceived(). 155 // OnSignalReceived().
155 on_signal_callback_.Run(signal); 156 on_signal_callback_.Run(signal);
156 } 157 }
157 158
158 void ServiceProviderTestHelper::OnResponse(dbus::Response* response) { 159 void ServiceProviderTestHelper::OnResponse(
159 response_.reset(response); 160 scoped_ptr<dbus::Response> response) {
161 response_ = response.Pass();
160 response_received_ = true; 162 response_received_ = true;
161 if (message_loop_.is_running()) 163 if (message_loop_.is_running())
162 message_loop_.Quit(); 164 message_loop_.Quit();
163 } 165 }
164 166
165 } // namespace chromeos 167 } // namespace chromeos
166
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698