Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1209173004: Roll breakpad r1459 -> r1465. (Closed)

Created:
5 years, 5 months ago by simonb (inactive)
Modified:
5 years, 5 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll breakpad r1459 -> r1465. r1465 Adjust breakpad module size to match adjusted start_addr. r1464 Checking location of the instruction pointer to see if it is in valid code for Linux exploitability rating. r1462 Reconfigured options for sym_upload to not treat h and ? flags as invalid options. r1461 [microdump] Trim newline characters from input lines. r1460 Use local variable for out parameter rather than direct use of ivar BUG=504410, 499747 Committed: https://crrev.com/df47c031d0021758f825b92db00fde4d9d77959e Cr-Commit-Position: refs/heads/master@{#336797}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
simonb (inactive)
5 years, 5 months ago (2015-06-30 14:26:17 UTC) #2
rmcilroy
On 2015/06/30 14:26:17, simonb wrote: lgtm
5 years, 5 months ago (2015-06-30 15:21:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209173004/1
5 years, 5 months ago (2015-06-30 15:42:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-30 16:52:44 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 16:53:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df47c031d0021758f825b92db00fde4d9d77959e
Cr-Commit-Position: refs/heads/master@{#336797}

Powered by Google App Engine
This is Rietveld 408576698