chrome/common/extensions/manifest_tests/extension_manifest_test.h - Issue 12091115: Allow manifest handlers to declare keys they depend on that must be parsed before them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifest_test.h

Issue 12091115: Allow manifest handlers to declare keys they depend on that must be parsed before them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: dcronin Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handler_unittest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifest_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifest_test.h

diff --git a/chrome/common/extensions/manifest_tests/extension_manifest_test.h b/chrome/common/extensions/manifest_tests/extension_manifest_test.h

index b1c330d1caf2b58d8e66173bd435ffe9e45d655d..d803408e6c39f0cbee34cf0bba3c7a88f3ccc556 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifest_test.h

+++ b/chrome/common/extensions/manifest_tests/extension_manifest_test.h

@@ -13,14 +13,13 @@

#include "chrome/common/extensions/manifest.h"

#include "testing/gtest/include/gtest/gtest.h"

-namespace errors = extension_manifest_errors;

-namespace keys = extension_manifest_keys;

class ExtensionManifestTest : public testing::Test {

public:

ExtensionManifestTest();

protected:

+ virtual void SetUp() OVERRIDE;

// If filename is a relative path, LoadManifestFile will treat it relative to

// the appropriate test directory.

static DictionaryValue* LoadManifestFile(const std::string& filename,