chrome/browser/extensions/manifest_url_parser.cc - Issue 12091115: Allow manifest handlers to declare keys they depend on that must be parsed before them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/manifest_url_parser.cc

Issue 12091115: Allow manifest handlers to declare keys they depend on that must be parsed before them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: dcronin Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_special_storage_policy_unittest.cc ('k') | chrome/browser/extensions/sandboxed_unpacker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/manifest_url_parser.cc

diff --git a/chrome/browser/extensions/manifest_url_parser.cc b/chrome/browser/extensions/manifest_url_parser.cc

index 313dadd2c8e6f0d929e822b4769f3a597574f428..927db0705781d745924bd92c50d17e306011e01e 100644

--- a/chrome/browser/extensions/manifest_url_parser.cc

+++ b/chrome/browser/extensions/manifest_url_parser.cc

@@ -19,15 +19,15 @@ namespace extensions {

ManifestURLParser::ManifestURLParser(Profile* profile)

: profile_(profile) {

ManifestHandler::Register(extension_manifest_keys::kDevToolsPage,

- new DevToolsPageHandler);

+ make_linked_ptr(new DevToolsPageHandler));

ManifestHandler::Register(extension_manifest_keys::kHomepageURL,

- new HomepageURLHandler);

+ make_linked_ptr(new HomepageURLHandler));

ManifestHandler::Register(extension_manifest_keys::kUpdateURL,

- new UpdateURLHandler);

+ make_linked_ptr(new UpdateURLHandler));

ManifestHandler::Register(extension_manifest_keys::kOptionsPage,

- new OptionsPageHandler);

+ make_linked_ptr(new OptionsPageHandler));

ManifestHandler::Register(extension_manifest_keys::kChromeURLOverrides,

- new URLOverridesHandler);

+ make_linked_ptr(new URLOverridesHandler));

registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_LOADED,

content::Source<Profile>(profile));