Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc

Issue 12091115: Allow manifest handlers to declare keys they depend on that must be parsed before them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: dcronin Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension_manifest_constants.h" 5 #include "chrome/common/extensions/extension_manifest_constants.h"
6 #include "chrome/common/extensions/manifest_handler.h" 6 #include "chrome/common/extensions/manifest_handler.h"
7 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 7 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
8 #include "chrome/common/extensions/manifest_url_handler.h" 8 #include "chrome/common/extensions/manifest_url_handler.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 using extensions::Extension; 11 using extensions::Extension;
12 12
13 namespace errors = extension_manifest_errors; 13 namespace errors = extension_manifest_errors;
14 14
15 class UpdateURLManifestTest : public ExtensionManifestTest { 15 class UpdateURLManifestTest : public ExtensionManifestTest {
16 virtual void SetUp() OVERRIDE { 16 virtual void SetUp() OVERRIDE {
17 ExtensionManifestTest::SetUp(); 17 ExtensionManifestTest::SetUp();
18 extensions::ManifestHandler::Register(extension_manifest_keys::kUpdateURL, 18 extensions::ManifestHandler::Register(
19 new extensions::UpdateURLHandler); 19 extension_manifest_keys::kUpdateURL,
20 make_linked_ptr(new extensions::UpdateURLHandler));
20 } 21 }
21 }; 22 };
22 23
23 TEST_F(UpdateURLManifestTest, UpdateUrls) { 24 TEST_F(UpdateURLManifestTest, UpdateUrls) {
24 // Test several valid update urls 25 // Test several valid update urls
25 Testcase testcases[] = { 26 Testcase testcases[] = {
26 Testcase("update_url_valid_1.json", extensions::Manifest::INTERNAL, 27 Testcase("update_url_valid_1.json", extensions::Manifest::INTERNAL,
27 Extension::NO_FLAGS), 28 Extension::NO_FLAGS),
28 Testcase("update_url_valid_2.json", extensions::Manifest::INTERNAL, 29 Testcase("update_url_valid_2.json", extensions::Manifest::INTERNAL,
29 Extension::NO_FLAGS), 30 Extension::NO_FLAGS),
(...skipping 10 matching lines...) Expand all
40 Testcase("update_url_invalid_1.json", errors::kInvalidUpdateURL, 41 Testcase("update_url_invalid_1.json", errors::kInvalidUpdateURL,
41 extensions::Manifest::INTERNAL, Extension::NO_FLAGS), 42 extensions::Manifest::INTERNAL, Extension::NO_FLAGS),
42 Testcase("update_url_invalid_2.json", errors::kInvalidUpdateURL, 43 Testcase("update_url_invalid_2.json", errors::kInvalidUpdateURL,
43 extensions::Manifest::INTERNAL, Extension::NO_FLAGS), 44 extensions::Manifest::INTERNAL, Extension::NO_FLAGS),
44 Testcase("update_url_invalid_3.json", errors::kInvalidUpdateURL, 45 Testcase("update_url_invalid_3.json", errors::kInvalidUpdateURL,
45 extensions::Manifest::INTERNAL, Extension::NO_FLAGS) 46 extensions::Manifest::INTERNAL, Extension::NO_FLAGS)
46 }; 47 };
47 RunTestcases(testcases2, arraysize(testcases2), 48 RunTestcases(testcases2, arraysize(testcases2),
48 EXPECT_TYPE_ERROR); 49 EXPECT_TYPE_ERROR);
49 } 50 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698