Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_override_unittest.cc

Issue 12091115: Allow manifest handlers to declare keys they depend on that must be parsed before them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: dcronin Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension_manifest_constants.h" 5 #include "chrome/common/extensions/extension_manifest_constants.h"
6 #include "chrome/common/extensions/manifest_handler.h" 6 #include "chrome/common/extensions/manifest_handler.h"
7 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 7 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
8 #include "chrome/common/extensions/manifest_url_handler.h" 8 #include "chrome/common/extensions/manifest_url_handler.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 namespace errors = extension_manifest_errors; 11 namespace errors = extension_manifest_errors;
12 12
13 class URLOverridesManifestTest : public ExtensionManifestTest { 13 class URLOverridesManifestTest : public ExtensionManifestTest {
14 virtual void SetUp() OVERRIDE { 14 virtual void SetUp() OVERRIDE {
15 ExtensionManifestTest::SetUp(); 15 ExtensionManifestTest::SetUp();
16 extensions::ManifestHandler::Register(keys::kChromeURLOverrides, 16 extensions::ManifestHandler::Register(
17 new extensions::URLOverridesHandler); 17 extension_manifest_keys::kChromeURLOverrides,
18 make_linked_ptr(new extensions::URLOverridesHandler));
18 } 19 }
19 }; 20 };
20 21
21 TEST_F(URLOverridesManifestTest, Override) { 22 TEST_F(URLOverridesManifestTest, Override) {
22 Testcase testcases[] = { 23 Testcase testcases[] = {
23 Testcase("override_newtab_and_history.json", errors::kMultipleOverrides), 24 Testcase("override_newtab_and_history.json", errors::kMultipleOverrides),
24 Testcase("override_invalid_page.json", errors::kInvalidChromeURLOverrides) 25 Testcase("override_invalid_page.json", errors::kInvalidChromeURLOverrides)
25 }; 26 };
26 RunTestcases(testcases, arraysize(testcases), 27 RunTestcases(testcases, arraysize(testcases),
27 EXPECT_TYPE_ERROR); 28 EXPECT_TYPE_ERROR);
28 29
29 scoped_refptr<extensions::Extension> extension; 30 scoped_refptr<extensions::Extension> extension;
30 31
31 extension = LoadAndExpectSuccess("override_new_tab.json"); 32 extension = LoadAndExpectSuccess("override_new_tab.json");
32 EXPECT_EQ(extension->url().spec() + "newtab.html", 33 EXPECT_EQ(extension->url().spec() + "newtab.html",
33 extensions::URLOverrides::GetChromeURLOverrides(extension). 34 extensions::URLOverrides::GetChromeURLOverrides(extension).
34 find("newtab")->second.spec()); 35 find("newtab")->second.spec());
35 36
36 extension = LoadAndExpectSuccess("override_history.json"); 37 extension = LoadAndExpectSuccess("override_history.json");
37 EXPECT_EQ(extension->url().spec() + "history.html", 38 EXPECT_EQ(extension->url().spec() + "history.html",
38 extensions::URLOverrides::GetChromeURLOverrides(extension). 39 extensions::URLOverrides::GetChromeURLOverrides(extension).
39 find("history")->second.spec()); 40 find("history")->second.spec());
40 } 41 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698