Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: chrome/browser/ui/autofill/tab_autofill_manager_delegate.h

Issue 12091086: [Autofill] Add UMA timing metrics for requestAutocomplete dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase harder Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/tab_autofill_manager_delegate.h
diff --git a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.h b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.h
index 98093b4b4de1d0ab57f9f531d234546e6e138517..735df823a067364183b83ab2c471768468532d55 100644
--- a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.h
+++ b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.h
@@ -11,24 +11,25 @@
#include "content/public/browser/web_contents_observer.h"
#include "content/public/browser/web_contents_user_data.h"
-namespace autofill {
-class AutofillDialogControllerImpl;
-}
-
namespace content {
struct FrameNavigateParams;
struct LoadCommittedDetails;
class WebContents;
}
+namespace autofill {
+
+class AutofillDialogControllerImpl;
+
// Chrome implementation of AutofillManagerDelegate.
class TabAutofillManagerDelegate
- : public autofill::AutofillManagerDelegate,
+ : public AutofillManagerDelegate,
public content::WebContentsUserData<TabAutofillManagerDelegate>,
public content::WebContentsObserver {
public:
virtual ~TabAutofillManagerDelegate() {}
+ // AutofillManagerDelegate implementation.
virtual content::BrowserContext* GetBrowserContext() const OVERRIDE;
virtual content::BrowserContext* GetOriginalBrowserContext() const OVERRIDE;
virtual Profile* GetOriginalProfile() const OVERRIDE;
@@ -40,7 +41,7 @@ class TabAutofillManagerDelegate
virtual void ShowPasswordGenerationBubble(
const gfx::Rect& bounds,
const content::PasswordForm& form,
- autofill::PasswordGenerator* generator) OVERRIDE;
+ PasswordGenerator* generator) OVERRIDE;
virtual void ShowAutocheckoutBubble(
const gfx::RectF& bounds,
const gfx::NativeView& native_view,
@@ -49,6 +50,8 @@ class TabAutofillManagerDelegate
const FormData& form,
const GURL& source_url,
const content::SSLStatus& ssl_status,
+ const AutofillMetrics& metric_logger,
+ DialogType dialog_type,
const base::Callback<void(const FormStructure*)>& callback) OVERRIDE;
virtual void RequestAutocompleteDialogClosed() OVERRIDE;
virtual void UpdateProgressBar(double value) OVERRIDE;
@@ -66,9 +69,11 @@ class TabAutofillManagerDelegate
void HideRequestAutocompleteDialog();
content::WebContents* const web_contents_;
- autofill::AutofillDialogControllerImpl* autofill_dialog_controller_; // weak.
+ AutofillDialogControllerImpl* autofill_dialog_controller_; // weak.
DISALLOW_COPY_AND_ASSIGN(TabAutofillManagerDelegate);
};
+} // namespace autofill
+
#endif // CHROME_BROWSER_UI_AUTOFILL_TAB_AUTOFILL_MANAGER_DELEGATE_H_
« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_view.h ('k') | chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698