Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

Issue 12091086: [Autofill] Add UMA timing metrics for requestAutocomplete dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase harder Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
index 851c7d2b253bbf3505001192b447fe716c23654e..2bc179c29b908bea5f6922ec31b82d717bdff1fa 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
@@ -11,6 +11,9 @@
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/string16.h"
+#include "base/time.h"
+#include "chrome/browser/autofill/autofill_manager_delegate.h"
+#include "chrome/browser/autofill/autofill_metrics.h"
#include "chrome/browser/autofill/field_types.h"
#include "chrome/browser/autofill/form_structure.h"
#include "chrome/browser/autofill/personal_data_manager.h"
@@ -56,6 +59,8 @@ class AutofillDialogControllerImpl : public AutofillDialogController,
const FormData& form_structure,
const GURL& source_url,
const content::SSLStatus& ssl_status,
+ const AutofillMetrics& metric_logger,
+ const DialogType dialog_type,
const base::Callback<void(const FormStructure*)>& callback);
virtual ~AutofillDialogControllerImpl();
@@ -149,6 +154,10 @@ class AutofillDialogControllerImpl : public AutofillDialogController,
// PersonalDataManagerObserver implementation.
virtual void OnPersonalDataChanged() OVERRIDE;
+ protected:
+ // Exposed for testing.
+ AutofillDialogView* view() { return view_.get(); }
+
private:
// Refresh wallet items immediately if there's no refresh currently in
// progress, otherwise wait until the current refresh completes.
@@ -297,6 +306,11 @@ class AutofillDialogControllerImpl : public AutofillDialogController,
// A NotificationRegistrar for tracking the completion of sign-in.
content::NotificationRegistrar registrar_;
+ // For logging UMA metrics.
+ const AutofillMetrics& metric_logger_;
+ base::Time dialog_shown_timestamp_;
+ DialogType dialog_type_;
+
DISALLOW_COPY_AND_ASSIGN(AutofillDialogControllerImpl);
};

Powered by Google App Engine
This is Rietveld 408576698