Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: chrome/browser/autofill/autocheckout_manager.cc

Issue 12091086: [Autofill] Add UMA timing metrics for requestAutocomplete dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase harder Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autocheckout_manager.cc
diff --git a/chrome/browser/autofill/autocheckout_manager.cc b/chrome/browser/autofill/autocheckout_manager.cc
index 034a89f3337604c74181cf7f5303a3e5fc78c87a..e96a37857af22afb69807826080a4820cd3d9e44 100644
--- a/chrome/browser/autofill/autocheckout_manager.cc
+++ b/chrome/browser/autofill/autocheckout_manager.cc
@@ -68,6 +68,8 @@ FormData BuildAutocheckoutFormData() {
} // namespace
+namespace autofill {
+
AutocheckoutManager::AutocheckoutManager(AutofillManager* autofill_manager)
: autofill_manager_(autofill_manager),
autocheckout_bubble_shown_(false),
@@ -113,7 +115,7 @@ void AutocheckoutManager::FillForms() {
}
void AutocheckoutManager::OnLoadedPageMetaData(
- scoped_ptr<autofill::AutocheckoutPageMetaData> page_meta_data) {
+ scoped_ptr<AutocheckoutPageMetaData> page_meta_data) {
page_meta_data_ = page_meta_data.Pass();
}
@@ -148,8 +150,9 @@ void AutocheckoutManager::ShowAutocheckoutDialog(
base::Callback<void(const FormStructure*)> callback =
base::Bind(&AutocheckoutManager::ReturnAutocheckoutData,
weak_ptr_factory_.GetWeakPtr());
- autofill_manager_->delegate()->ShowRequestAutocompleteDialog(
- BuildAutocheckoutFormData(), frame_url, ssl_status, callback);
+ autofill_manager_->ShowRequestAutocompleteDialog(
+ BuildAutocheckoutFormData(), frame_url, ssl_status,
+ DIALOG_TYPE_AUTOCHECKOUT, callback);
}
bool AutocheckoutManager::IsStartOfAutofillableFlow() const {
@@ -230,3 +233,5 @@ void AutocheckoutManager::SetValue(const AutofillField& field,
else
profile_->FillFormField(field, 0, field_to_fill);
}
+
+} // namespace autofill
« no previous file with comments | « chrome/browser/autofill/autocheckout_manager.h ('k') | chrome/browser/autofill/autocheckout_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698