Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

Issue 12091086: [Autofill] Add UMA timing metrics for requestAutocomplete dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove the "autocomplete" prefix Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
index 0d86fa939a3a8d89f3f0832ce6806cddac33e7d6..3aeff83ee702d2299b60bd6b5ddb4bf005fc576a 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
@@ -10,6 +10,9 @@
#include "base/callback.h"
#include "base/memory/scoped_ptr.h"
#include "base/string16.h"
+#include "base/time.h"
+#include "chrome/browser/autofill/autofill_manager_delegate.h"
+#include "chrome/browser/autofill/autofill_metrics.h"
#include "chrome/browser/autofill/field_types.h"
#include "chrome/browser/autofill/form_structure.h"
#include "chrome/browser/autofill/personal_data_manager.h"
@@ -52,6 +55,8 @@ class AutofillDialogControllerImpl : public AutofillDialogController,
const FormData& form_structure,
const GURL& source_url,
const content::SSLStatus& ssl_status,
+ const AutofillMetrics& metric_logger,
+ const DialogRequester requester,
const base::Callback<void(const FormStructure*)>& callback);
virtual ~AutofillDialogControllerImpl();
@@ -267,6 +272,11 @@ class AutofillDialogControllerImpl : public AutofillDialogController,
// A NotificationRegistrar for tracking the completion of sign-in.
content::NotificationRegistrar registrar_;
+ // For logging UMA metrics.
+ const base::Time dialog_shown_timestamp_;
+ const AutofillMetrics& metric_logger_;
+ DialogRequester requester_;
+
DISALLOW_COPY_AND_ASSIGN(AutofillDialogControllerImpl);
};

Powered by Google App Engine
This is Rietveld 408576698