Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: chrome/browser/autofill/autofill_manager.cc

Issue 12091086: [Autofill] Add UMA timing metrics for requestAutocomplete dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove the "autocomplete" prefix Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autofill_manager.cc
diff --git a/chrome/browser/autofill/autofill_manager.cc b/chrome/browser/autofill/autofill_manager.cc
index cbdcbaeebac3d6b3665bac8317807aed8cf77841..e01592a0b8a9d894a68dca361968879caf6ded0c 100644
--- a/chrome/browser/autofill/autofill_manager.cc
+++ b/chrome/browser/autofill/autofill_manager.cc
@@ -582,7 +582,7 @@ void AutofillManager::OnQueryFormFieldAutofill(int query_id,
// Autofill server said so), then trigger payments UI while also returning
// standard autofill suggestions to renderer process.
if (page_meta_data_.IsStartOfAutofillableFlow()) {
- AutocheckoutInfoBarDelegate::Create(
+ autofill::AutocheckoutInfoBarDelegate::Create(
*metric_logger_,
form.origin,
form.ssl_status,
@@ -787,9 +787,10 @@ void AutofillManager::ShowRequestAutocompleteDialog(
const FormData& form,
const GURL& source_url,
const content::SSLStatus& ssl_status,
+ autofill::DialogRequester requester,
const base::Callback<void(const FormStructure*)>& callback) {
manager_delegate_->ShowRequestAutocompleteDialog(
- form, source_url, ssl_status, callback);
+ form, source_url, ssl_status, *metric_logger_, requester, callback);
}
void AutofillManager::RequestAutocompleteDialogClosed() {
@@ -840,7 +841,9 @@ void AutofillManager::OnRequestAutocomplete(
base::Callback<void(const FormStructure*)> callback =
base::Bind(&AutofillManager::ReturnAutocompleteData, this);
- ShowRequestAutocompleteDialog(form, frame_url, ssl_status, callback);
+ ShowRequestAutocompleteDialog(
+ form, frame_url, ssl_status,
+ autofill::DIALOG_REQUESTER_REQUEST_AUTOCOMPLETE, callback);
}
void AutofillManager::ReturnAutocompleteResult(

Powered by Google App Engine
This is Rietveld 408576698