Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Side by Side Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

Issue 12091086: [Autofill] Add UMA timing metrics for requestAutocomplete dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Moar vertical whitespace Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_ 5 #ifndef CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_
6 #define CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_ 6 #define CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/memory/scoped_ptr.h" 11 #include "base/memory/scoped_ptr.h"
12 #include "base/string16.h" 12 #include "base/string16.h"
13 #include "base/time.h"
14 #include "chrome/browser/autofill/autofill_metrics.h"
13 #include "chrome/browser/autofill/field_types.h" 15 #include "chrome/browser/autofill/field_types.h"
14 #include "chrome/browser/autofill/form_structure.h" 16 #include "chrome/browser/autofill/form_structure.h"
15 #include "chrome/browser/autofill/personal_data_manager.h" 17 #include "chrome/browser/autofill/personal_data_manager.h"
16 #include "chrome/browser/autofill/wallet/required_action.h" 18 #include "chrome/browser/autofill/wallet/required_action.h"
17 #include "chrome/browser/autofill/wallet/wallet_client.h" 19 #include "chrome/browser/autofill/wallet/wallet_client.h"
18 #include "chrome/browser/autofill/wallet/wallet_client_observer.h" 20 #include "chrome/browser/autofill/wallet/wallet_client_observer.h"
19 #include "chrome/browser/ui/autofill/autofill_dialog_controller.h" 21 #include "chrome/browser/ui/autofill/autofill_dialog_controller.h"
20 #include "chrome/browser/ui/autofill/autofill_dialog_models.h" 22 #include "chrome/browser/ui/autofill/autofill_dialog_models.h"
21 #include "chrome/browser/ui/autofill/autofill_dialog_types.h" 23 #include "chrome/browser/ui/autofill/autofill_dialog_types.h"
22 #include "chrome/browser/ui/autofill/autofill_popup_controller_impl.h" 24 #include "chrome/browser/ui/autofill/autofill_popup_controller_impl.h"
(...skipping 22 matching lines...) Expand all
45 public AutofillPopupDelegate, 47 public AutofillPopupDelegate,
46 public content::NotificationObserver, 48 public content::NotificationObserver,
47 public SuggestionsMenuModelDelegate, 49 public SuggestionsMenuModelDelegate,
48 public wallet::WalletClientObserver { 50 public wallet::WalletClientObserver {
49 public: 51 public:
50 AutofillDialogControllerImpl( 52 AutofillDialogControllerImpl(
51 content::WebContents* contents, 53 content::WebContents* contents,
52 const FormData& form_structure, 54 const FormData& form_structure,
53 const GURL& source_url, 55 const GURL& source_url,
54 const content::SSLStatus& ssl_status, 56 const content::SSLStatus& ssl_status,
57 const AutofillMetrics& metric_logger,
55 const base::Callback<void(const FormStructure*)>& callback); 58 const base::Callback<void(const FormStructure*)>& callback);
56 virtual ~AutofillDialogControllerImpl(); 59 virtual ~AutofillDialogControllerImpl();
57 60
58 void Show(); 61 void Show();
59 void Hide(); 62 void Hide();
60 63
61 // AutofillDialogController implementation. 64 // AutofillDialogController implementation.
62 virtual string16 DialogTitle() const OVERRIDE; 65 virtual string16 DialogTitle() const OVERRIDE;
63 virtual string16 EditSuggestionText() const OVERRIDE; 66 virtual string16 EditSuggestionText() const OVERRIDE;
64 virtual string16 UseBillingForShippingText() const OVERRIDE; 67 virtual string16 UseBillingForShippingText() const OVERRIDE;
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 258
256 // The section for which |popup_controller_| is currently showing a popup 259 // The section for which |popup_controller_| is currently showing a popup
257 // (if any). 260 // (if any).
258 DialogSection section_showing_popup_; 261 DialogSection section_showing_popup_;
259 262
260 scoped_ptr<AutofillDialogView> view_; 263 scoped_ptr<AutofillDialogView> view_;
261 264
262 // A NotificationRegistrar for tracking the completion of sign-in. 265 // A NotificationRegistrar for tracking the completion of sign-in.
263 content::NotificationRegistrar registrar_; 266 content::NotificationRegistrar registrar_;
264 267
268 // For logging UMA metrics.
269 const base::Time dialog_shown_timestamp_;
270 const AutofillMetrics& metric_logger_;
271
265 DISALLOW_COPY_AND_ASSIGN(AutofillDialogControllerImpl); 272 DISALLOW_COPY_AND_ASSIGN(AutofillDialogControllerImpl);
266 }; 273 };
267 274
268 } // namespace autofill 275 } // namespace autofill
269 276
270 #endif // CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_ 277 #endif // CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698