[Autofill] Add UMA timing metrics for requestAutocomplete dialog.

chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h"
 
 #include <string>
 
 #include "base/logging.h"
 #include "base/string_split.h"
@@ skipping 107 matching lines @@
 
 }  // namespace
 
 AutofillDialogController::~AutofillDialogController() {}
 
 AutofillDialogControllerImpl::AutofillDialogControllerImpl(
     content::WebContents* contents,
     const FormData& form,
     const GURL& source_url,
     const content::SSLStatus& ssl_status,
+    const AutofillMetrics& metric_logger,
     const base::Callback<void(const FormStructure*)>& callback)
     : profile_(Profile::FromBrowserContext(contents->GetBrowserContext())),
       contents_(contents),
       form_structure_(form),
       source_url_(source_url),
       ssl_status_(ssl_status),
       callback_(callback),
       wallet_client_(profile_->GetRequestContext()),
       ALLOW_THIS_IN_INITIALIZER_LIST(suggested_email_(this)),
       ALLOW_THIS_IN_INITIALIZER_LIST(suggested_cc_(this)),
       ALLOW_THIS_IN_INITIALIZER_LIST(suggested_billing_(this)),
       ALLOW_THIS_IN_INITIALIZER_LIST(suggested_shipping_(this)),
       popup_controller_(NULL),
-      section_showing_popup_(SECTION_BILLING) {
+      section_showing_popup_(SECTION_BILLING),
+      dialog_shown_timestamp_(base::Time::Now()),
+      metric_logger_(metric_logger) {
   // TODO(estade): |this| should observe PersonalDataManager.
   // TODO(estade): remove duplicates from |form|?
 
   content::NavigationEntry* entry = contents->GetController().GetActiveEntry();
   const GURL& active_url = entry ? entry->GetURL() : web_contents()->GetURL();
   invoked_from_same_origin_ = active_url.GetOrigin() == source_url_.GetOrigin();
 }
 
 AutofillDialogControllerImpl::~AutofillDialogControllerImpl() {
   if (popup_controller_)
@@ skipping 331 matching lines @@
                           popup_icons,
                           popup_ids);
   section_showing_popup_ = section;
 }
 
 void AutofillDialogControllerImpl::FocusMoved() {
   HidePopup();
 }
 
 void AutofillDialogControllerImpl::ViewClosed(DialogAction action) {
+  const base::TimeDelta dialog_duration =
+      base::Time::Now() - dialog_shown_timestamp_;

[Dan Beam, 2013/01/31 19:47:16]

opt nit: used once, inline, also

  DialogDismissalAction dismissal_action;

[Ilya Sherman, 2013/02/01 09:55:17]

Done.

+
   if (action == ACTION_SUBMIT) {
     FillOutputForSection(SECTION_EMAIL);
     FillOutputForSection(SECTION_CC);
     FillOutputForSection(SECTION_BILLING);
     if (view_->UseBillingForShipping()) {
       FillOutputForSectionWithComparator(
           SECTION_BILLING,
           base::Bind(DetailInputMatchesShippingField));
       FillOutputForSectionWithComparator(
           SECTION_CC,
           base::Bind(DetailInputMatchesShippingField));
     } else {
       FillOutputForSection(SECTION_SHIPPING);
     }
     callback_.Run(&form_structure_);
+    metric_logger_.LogRequestAutocompleteUiDuration(
+        dialog_duration, AutofillMetrics::DIALOG_ACCEPTED);

[Dan Beam, 2013/01/31 19:47:16]

opt nit:

  dismissal_action = AutofillMetrics::DIALOG_ACCEPTED;

[Ilya Sherman, 2013/02/01 09:55:17]

Done.

   } else {
     callback_.Run(NULL);
+    metric_logger_.LogRequestAutocompleteUiDuration(
+        dialog_duration, AutofillMetrics::DIALOG_CANCELED);

[Dan Beam, 2013/01/31 19:47:16]

opt nit:

  dismissal_action = AutofillMetrics::DIALOG_CANCELED;

[Ilya Sherman, 2013/02/01 09:55:17]

Done.

   }

[Dan Beam, 2013/01/31 19:47:16]

opt nit:

  metric_logger_.LogRequestAutocompleteUiDuration(
      base::Time::Now() - dialog_shown_timestamp_, dismissal_action);

[Ilya Sherman, 2013/02/01 09:55:17]

Done.

 
   delete this;
 }
 
 DialogNotification AutofillDialogControllerImpl::CurrentNotification() const {
   if (wallet_items_ && !wallet_items_->required_actions().empty()) {
     switch (wallet_items_->required_actions()[0]) {
       case wallet::UNKNOWN_TYPE:
         NOTREACHED();
         break;
@@ skipping 401 matching lines @@
 }
 
 void AutofillDialogControllerImpl::HidePopup() {
   if (popup_controller_) {
     popup_controller_->Hide();
     ControllerDestroyed();
   }
 }
 
 }  // namespace autofill