[Autofill] Add UMA timing metrics for requestAutocomplete dialog.

chrome/browser/autofill/autofill_metrics.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_METRICS_H_
 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_METRICS_H_
 
 #include <stddef.h>
 #include <string>
 
 #include "base/basictypes.h"
 #include "chrome/browser/autofill/field_types.h"
 
 namespace base {
 class TimeDelta;
 }
 
 class AutofillMetrics {
  public:
   enum DeveloperEngagementMetric {
     // Parsed a form that is potentially autofillable.
     FILLABLE_FORM_PARSED = 0,
     // Parsed a form that is potentially autofillable and contains at least one
     // web developer-specified field type hint, a la
     // http://is.gd/whatwg_autocomplete
     FILLABLE_FORM_CONTAINS_TYPE_HINTS,
     NUM_DEVELOPER_ENGAGEMENT_METRICS
   };
 
+  // The action the user took to dismiss a dialog.
+  enum DialogDismissalAction {
+    DIALOG_ACCEPTED = 0,  // The user accepted, i.e. confirmed, the dialog.
+    DIALOG_CANCELED       // The user canceled out of the dialog.

[Dan Beam, 2013/01/31 19:47:16]

super optional nit: trailing ,

[Ilya Sherman, 2013/02/01 09:55:17]

Left it out to be consistent with the rest of the file.

[Dan Beam, 2013/02/01 17:18:08]

Why does the rest of the file hate , :P?

+  };
+
   enum InfoBarMetric {
     INFOBAR_SHOWN = 0,  // We showed an infobar, e.g. prompting to save credit
                         // card info.
     INFOBAR_ACCEPTED,   // The user explicitly accepted the infobar.
     INFOBAR_DENIED,     // The user explicitly denied the infobar.
     INFOBAR_IGNORED,    // The user completely ignored the infobar (logged on
                         // tab close).
     NUM_INFO_BAR_METRICS
   };
 
@@ skipping 111 matching lines @@
 
   virtual void LogQualityMetric(QualityMetric metric,
                                 const std::string& experiment_id) const;
 
   virtual void LogServerQueryMetric(ServerQueryMetric metric) const;
 
   virtual void LogUserHappinessMetric(UserHappinessMetric metric) const;
 
   virtual void LogAutocheckoutInfoBarMetric(InfoBarMetric metric) const;
 
+  // This should be called when the requestAutocomplete dialog is closed.
+  // |duration| should be the time elapsed between the dialog being shown and it
+  // being closed.  |dismissal_action| should indicate whether the user
+  // dismissed the dialog by submitting the form data or by cancelling.
+  virtual void LogRequestAutocompleteUiDuration(
+      const base::TimeDelta& duration,
+      DialogDismissalAction dismissal_action) const;
+
   // This should be called when a form that has been Autofilled is submitted.
   // |duration| should be the time elapsed between form load and submission.
   virtual void LogFormFillDurationFromLoadWithAutofill(
       const base::TimeDelta& duration) const;
 
   // This should be called when a fillable form that has not been Autofilled is
   // submitted.  |duration| should be the time elapsed between form load and
   // submission.
   virtual void LogFormFillDurationFromLoadWithoutAutofill(
       const base::TimeDelta& duration) const;
@@ skipping 29 matching lines @@
 
   // Logs the experiment id corresponding to an upload to the server.
   virtual void LogServerExperimentIdForUpload(
       const std::string& experiment_id) const;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(AutofillMetrics);
 };
 
 #endif  // CHROME_BROWSER_AUTOFILL_AUTOFILL_METRICS_H_