Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Side by Side Diff: chrome/browser/autofill/autofill_metrics.cc

Issue 12091086: [Autofill] Add UMA timing metrics for requestAutocomplete dialog. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Moar vertical whitespace Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/autofill/autofill_metrics.h" 5 #include "chrome/browser/autofill/autofill_metrics.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "base/time.h" 9 #include "base/time.h"
10 #include "chrome/browser/autofill/autofill_type.h" 10 #include "chrome/browser/autofill/autofill_type.h"
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 NUM_INFO_BAR_METRICS); 261 NUM_INFO_BAR_METRICS);
262 } 262 }
263 263
264 void AutofillMetrics::LogAutocheckoutInfoBarMetric(InfoBarMetric metric) const { 264 void AutofillMetrics::LogAutocheckoutInfoBarMetric(InfoBarMetric metric) const {
265 DCHECK(metric < NUM_INFO_BAR_METRICS); 265 DCHECK(metric < NUM_INFO_BAR_METRICS);
266 266
267 UMA_HISTOGRAM_ENUMERATION("Autofill.AutocheckoutInfoBar", metric, 267 UMA_HISTOGRAM_ENUMERATION("Autofill.AutocheckoutInfoBar", metric,
268 NUM_INFO_BAR_METRICS); 268 NUM_INFO_BAR_METRICS);
269 } 269 }
270 270
271 void AutofillMetrics::LogRequestAutocompleteUiDuration(
272 const base::TimeDelta& duration,
273 DialogDismissalAction dismissal_action) const {
274 UMA_HISTOGRAM_LONG_TIMES("RequestAutocomplete.UiDuration", duration);
Albert Bodenhamer 2013/01/31 16:31:06 What's the best way to split this out by invocatio
Ilya Sherman 2013/02/01 09:55:17 Done.
275
276 switch (dismissal_action) {
277 case DIALOG_ACCEPTED:
278 UMA_HISTOGRAM_LONG_TIMES("RequestAutocomplete.UiDuration.Submit",
279 duration);
280 break;
281
282 case DIALOG_CANCELED:
283 UMA_HISTOGRAM_LONG_TIMES("RequestAutocomplete.UiDuration.Cancel",
284 duration);
285 break;
286 }
287 }
288
289
271 void AutofillMetrics::LogDeveloperEngagementMetric( 290 void AutofillMetrics::LogDeveloperEngagementMetric(
272 DeveloperEngagementMetric metric) const { 291 DeveloperEngagementMetric metric) const {
273 DCHECK(metric < NUM_DEVELOPER_ENGAGEMENT_METRICS); 292 DCHECK(metric < NUM_DEVELOPER_ENGAGEMENT_METRICS);
274 293
275 UMA_HISTOGRAM_ENUMERATION("Autofill.DeveloperEngagement", metric, 294 UMA_HISTOGRAM_ENUMERATION("Autofill.DeveloperEngagement", metric,
276 NUM_DEVELOPER_ENGAGEMENT_METRICS); 295 NUM_DEVELOPER_ENGAGEMENT_METRICS);
277 } 296 }
278 297
279 void AutofillMetrics::LogHeuristicTypePrediction( 298 void AutofillMetrics::LogHeuristicTypePrediction(
280 FieldTypeQualityMetric metric, 299 FieldTypeQualityMetric metric,
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
384 403
385 void AutofillMetrics::LogServerExperimentIdForQuery( 404 void AutofillMetrics::LogServerExperimentIdForQuery(
386 const std::string& experiment_id) const { 405 const std::string& experiment_id) const {
387 LogServerExperimentId("Autofill.ServerExperimentId.Query", experiment_id); 406 LogServerExperimentId("Autofill.ServerExperimentId.Query", experiment_id);
388 } 407 }
389 408
390 void AutofillMetrics::LogServerExperimentIdForUpload( 409 void AutofillMetrics::LogServerExperimentIdForUpload(
391 const std::string& experiment_id) const { 410 const std::string& experiment_id) const {
392 LogServerExperimentId("Autofill.ServerExperimentId.Upload", experiment_id); 411 LogServerExperimentId("Autofill.ServerExperimentId.Upload", experiment_id);
393 } 412 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698